Github user RaiSaurabh commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1684
  
    @michaelandrepearce @clebertsuconic 
    Please correct me if my understanding is wrong. I checked the code of 
OpenwireMesageConverter when we send a message using client if comes to 
(https://github.com/apache/activemq-artemis/blob/master/artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverter.java#L122)
 where we set all the internal headers with __HDR as message property and 
return the CoreMessage.
    If we try to receive the message from the Openwire client we use these 
message properties to set them as ActiveMQMessage object properties like ID 
etc. Now with the case, if I use the AMQP/ Core receiver the message that is 
fetched is in form of ICoreMessage in CoreAmqpConverter class 
(https://github.com/apache/activemq-artemis/blob/master/artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/CoreAmqpConverter.java#L104)
 and all the internal headers of Openwire are present as message properties. 
Hence I decided to stip it off from the CoreAmqpConverter class. I was not able 
to find any better place. If you could point me that would be great.


---

Reply via email to