Agree with Justin, I wouldn't stop this release unless it is a regression caused since 2.4.0. We can always do bug fix releases even if they only contain a couple of fixes if they are of high importance.
On Wed, Mar 14, 2018 at 7:09 PM, Justin Bertram <jbert...@apache.org> wrote: > So is this a regression or a new issue? If it's a regression then I think > it should be fixed. If it's a new issue then I think it should go in 2.5.1 > in short order. > > > Justin > > On Wed, Mar 14, 2018 at 5:23 PM, Michael André Pearce < > michael.andre.pea...@me.com> wrote: > >> Hi again, >> >> So I have managed to create an integration test that re-creates the >> problem. >> https://github.com/michaelandrepearce/activemq-artemis/tree/ >> NetworkHealthCheckIssue >> >> Essentially when NetworkHealthCheck detects network failure issue, the >> server is stopped, once the network issue is resolved, it obviously detects >> this and restart the server again. >> >> If prior to the network issue, a change validly is made (as we support >> reloading these sections) to broker.xml is made for address-settings, >> security-settings, address’s or queue’s these are lost when the server is >> restarted, when the above occurs. >> >> During the initialization stage it seems the broker is resetting it >> configured state back to the config that was very first loaded, not the >> config that was last/most recently reloaded. >> >> This in my view is a blocker as essentially broker is losing changed >> configured state and can cause obvious issues, when intermittent network >> issues occur, which in any system is likely at some point, either in >> disaster or network maintenance. >> >> Cheers >> Mike >> >> Sent from my iPhone >> >> > On 14 Mar 2018, at 21:02, Michael André Pearce < >> michael.andre.pea...@me.com> wrote: >> > >> > We’ve spotted a nasty issue, I’m trying to put an integration test >> together to have recreatable the problem, but taking me some time. >> > >> > Can you give me another 24hours? To create the test to share then for >> you to decide if the issue is blocking or not. >> > >> > >> > >> > Sent from my iPhone >> > >> >> On 14 Mar 2018, at 09:50, Francesco Nigro <nigro....@gmail.com> wrote: >> >> >> >> +1 >> >> >> >> Compiled and run some tests on it >> >> >> >> >> >> Il giorno mer 14 mar 2018 alle ore 10:46 Dejan Bosanac < >> de...@nighttale.net> >> >> ha scritto: >> >> >> >>> +1 >> >>> >> >>> Regards >> >>> -- >> >>> Dejan Bosanac >> >>> http://sensatic.net/about >> >>> >> >>> On Wed, Mar 14, 2018 at 12:25 AM, Christopher Shannon < >> >>> christopher.l.shan...@gmail.com> wrote: >> >>> >> >>>> +1 >> >>>> >> >>>> On Tue, Mar 13, 2018 at 4:05 PM, Timothy Bish <tabish...@gmail.com> >> >>> wrote: >> >>>>> On 03/12/2018 04:40 PM, Clebert Suconic wrote: >> >>>>>> >> >>>>>> I would like to propose an Apache ActiveMQ Artemis 2.5.0 release. >> >>>>>> >> >>>>>> This is a great release, with 190 tasks completed including bug >> fixes, >> >>>>>> improvements, new features and additional tasks. I really appreciate >> >>>>>> everyone's contribution on making this happening. Thank you so much! >> >>>>>> >> >>>>>> >> >>>>>> I would like to highlight the features introduced on this release: >> >>>>>> >> >>>>>> [ARTEMIS-853] - Support for exclusive consumers >> >>>>>> [ARTEMIS-1030] - Support equivilent ActiveMQ 5.x Virtual Topic >> Naming >> >>>>>> Abilities >> >>>>>> [ARTEMIS-1548] - Support CRL >> >>>>>> [ARTEMIS-1550] - Support LVQ for OpenWire >> >>>>>> [ARTEMIS-1600] - Support masked passwords in bootstrap.xm and >> >>>> login.config >> >>>>>> [ARTEMIS-1623] - create an ActiveMQServerPlugin for logging various >> >>>>>> broker events >> >>>>>> [ARTEMIS-1649] - enable openssl provider for Netty >> >>>>>> [ARTEMIS-1661] - Enable splitting of broker.xml into multiple files >> >>>>>> [ARTEMIS-1663] - Add enhanced message count and size metrics for >> >>> Queues >> >>>>>> >> >>>>>> >> >>>>>> Given the length of this release, please refer to JIRA for the >> >>>>>> complete report of fixes included on 2.5.0: >> >>>>>> >> >>>>>> >> >>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa? >> >>>> projectId=12315920&version=12342127 >> >>>>>> >> >>>>>> >> >>>>>> >> >>>>>> Source and binary distributions can be found here: >> >>>>>> >> >>> https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/2.5.0 >> >>>>>> >> >>>>>> >> >>>>>> The Maven repository is here: >> >>>>>> https://repository.apache.org/content/repositories/ >> >>>> orgapacheactivemq-1156 >> >>>>>> >> >>>>>> >> >>>>>> In case you want to give it a try with the maven repo on examples: >> >>>>>> >> >>>>>> http://activemq.apache.org/artemis/docs/latest/hacking- >> >>>> guide/validating-releases.html >> >>>>>> >> >>>>>> >> >>>>>> The source tag: >> >>>>>> >> >>>>>> https://git-wip-us.apache.org/repos/asf?p=activemq-artemis. >> >>>> git;a=tag;h=refs/tags/2.5.0 >> >>>>>> >> >>>>>> I will update the website after the vote has passed. >> >>>>>> >> >>>>>> >> >>>>>> >> >>>>>> [ ] +1 approve the release as Apache Artemis 2.4.0 >> >>>>>> [ ] +0 no opinion >> >>>>>> [ ] -1 disapprove (and reason why) >> >>>>>> >> >>>>>> Here's my +1 >> >>>>>> >> >>>>> >> >>>>> +1 >> >>>>> >> >>>>> * Validated license and notice files >> >>>>> * Validated signatures and checksums >> >>>>> * Ran the binary broker and ran some AMQP sample applications against >> >>> it >> >>>>> * Built from source and ran some of the tests >> >>>>> * Ran mvn -P release apache-rat:check to validate source files had >> >>>> license >> >>>>> headers >> >>>>> >> >>>>> -- >> >>>>> Tim Bish >> >>>>> twitter: @tabish121 >> >>>>> blog: http://timbish.blogspot.com/ >> >>>>> >> >>>> >> >>> >>
