clebertsuconic commented on a change in pull request #2459: ARTEMIS-2200 NPE
while dropping/failing large messages on paging
URL: https://github.com/apache/activemq-artemis/pull/2459#discussion_r248724979
##########
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java
##########
@@ -974,6 +974,7 @@ public void run() {
} catch (Throwable e) {
result.fail(e);
logger.error("appendDeleteRecord:" + e, e);
+ setErrorCondition(callback, null, e);
Review comment:
I understand you fixed a synchronization here, but I'm a bit concerned into
forcing a failure on the callback when non IO Errors have happened.
Do you really need this line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
