clebertsuconic commented on a change in pull request #2459: ARTEMIS-2200 NPE
while dropping/failing large messages on paging
URL: https://github.com/apache/activemq-artemis/pull/2459#discussion_r248726923
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
##########
@@ -1354,13 +1354,15 @@ public void done() {
*/
private void confirmLargeMessageSend(Transaction tx, final Message message)
throws Exception {
LargeServerMessage largeServerMessage = (LargeServerMessage) message;
- if (largeServerMessage.getPendingRecordID() >= 0) {
Review comment:
this shouldn't be necessary. The only caller is synchronizing
largeServerMessage.
I would look for the real cause here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
