michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253117361
##########
File path:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTConnectionManager.java
##########
@@ -163,13 +163,7 @@ synchronized void disconnect(boolean failure) {
private MQTTSessionState getSessionState(String clientId) {
/* [MQTT-3.1.2-4] Attach an existing session if one exists otherwise
create a new one. */
- MQTTSessionState state = MQTTSession.SESSIONS.get(clientId);
- if (state == null) {
- state = new MQTTSessionState(clientId);
- MQTTSession.SESSIONS.put(clientId, state);
- }
-
- return state;
+ return MQTTSession.getSessionState(clientId,
session.getServer().getIdentity());
Review comment:
-1 Ive raised this already, simply shouldnt be having static map holding
state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
