michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253318615
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/protocol/RemotingConnection.java
##########
@@ -245,6 +245,13 @@
*/
String getTransportLocalAddress();
+ /**
+ * Called when all connection related operations are completed.
+ */
+ default void connected() throws Exception {
Review comment:
As this introduces a notification about connections created, should ensure
that this is always called, and not dependent on a protocol logic, e.g. present
a callback to a protocol which could choose to do something, and then after it
produces a connection connected notification
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
