michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253319407
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
##########
@@ -47,7 +47,8 @@
SESSION_CREATED(26),
SESSION_CLOSED(27),
MESSAGE_DELIVERED(28),
- MESSAGE_EXPIRED(29);
+ MESSAGE_EXPIRED(29),
+ CONNECTION_CONNECTED(30);
Review comment:
Going through and running this, and running with notification plugin, i
notice every time your new CONNECTION_CONNECTED occurs, a SESSION_CREATED is
also sent.
digging deeper and looking going through the logic of the connect in
MQTTConnectionManager it seems this actually connected in the
MQTTConnectionManager maps over to CORE as a server session (e.g. connect in
mqtt protocol parlance == in core create a serversession), which means we
already get a SESSION_CREATED notification with that plugin, so is it actually
we want to ensure SESSION_CREATED notifications are not reliant on plugin
enabled, e.g. bring that from the plugin (either moving code into
ActiveMQServer and invoke always this notification like with consumers, or
another approach could be, MQTT ensuring that the plugin configured/ enabled
and the notification needed in the plugin is enabled).
populating and then just enhance that notification with e.g.
session.getRemotingConnection().getClientID()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
