michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253543767
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
##########
@@ -47,7 +47,8 @@
SESSION_CREATED(26),
SESSION_CLOSED(27),
MESSAGE_DELIVERED(28),
- MESSAGE_EXPIRED(29);
+ MESSAGE_EXPIRED(29),
+ CONNECTION_CONNECTED(30);
Review comment:
re
> The clientId is read from the client's connection message. The logic for
reading the clientId cannot be placed in the CORE code， when create a
connection or create a session.
during handling connect packet in MQTTConnectionManager, the clientid is set
on the connection BEFORE createServerSession as such it will be available when
the SESSION_CREATED notification is created,
MQTTConnectionManager lines 78, 79
```
session.getConnection().setClientID(clientId);
ServerSessionImpl serverSession = createServerSession(username, password);
```
just need to populate the extra field in the SESSION_CREATED which would be
available at the time via
```
session.getRemotingConnection().getClientID() .
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
