michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r255920956
########## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java ########## @@ -2954,7 +2955,13 @@ public void onNotification(org.apache.activemq.artemis.core.server.management.No if (!(notification.getType() instanceof CoreNotificationType)) return; CoreNotificationType type = (CoreNotificationType) notification.getType(); - TypedProperties prop = notification.getProperties(); + if (type == CoreNotificationType.SESSION_CREATED) { + TypedProperties props = notification.getProperties(); + //SESSION_CREATED notification should not be broadcast twice + if (props.getIntProperty(ManagementHelper.HDR_DISTANCE) > 0) { Review comment: Also isnt cyclic between nodes in cluster already avoided, because of filter in the cluster connection bridge where it does a HDR_DISTANCE < flow.maxHops. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services