clebertsuconic commented on a change in pull request #2561: ARTEMIS-2259 Client
session not exist if reattach timeout
URL: https://github.com/apache/activemq-artemis/pull/2561#discussion_r259368542
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
##########
@@ -1350,10 +1350,12 @@ public void preHandleFailover(RemotingConnection
connection) {
// Needs to be synchronized to prevent issues with occurring concurrently
with close()
@Override
- public void handleFailover(final RemotingConnection backupConnection,
ActiveMQException cause) {
+ public boolean handleFailover(final RemotingConnection backupConnection,
ActiveMQException cause) {
Review comment:
true usually means success. this is a bit confusing. Can you make it
opposite.
meaning handleFailover would return true if succeeded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
