clebertsuconic commented on a change in pull request #2561: ARTEMIS-2259 Client
session not exist if reattach timeout
URL: https://github.com/apache/activemq-artemis/pull/2561#discussion_r259926106
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java
##########
@@ -771,7 +771,11 @@ private void reconnectSessions(final RemotingConnection
oldConnection,
((CoreRemotingConnection)
connection).syncIDGeneratorSequence(((CoreRemotingConnection)
oldConnection).getIDGeneratorSequence());
for (ClientSessionInternal session : sessionsToFailover) {
- session.handleFailover(connection, cause);
+ if (session.handleFailover(connection, cause)) {
+ connection.destroy();
Review comment:
Well.. .the thing is... I"m not sure what was the problem to be able to tell
you what is the fix. a test would help.
If you can't provide a test.. for something rare happening in production, it
would be nice some more details.. like logs.. stack traces....
i couldn't figure out the issue by just the synchrnoized implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
