clebertsuconic commented on a change in pull request #2561: ARTEMIS-2259 Client
session not exist if reattach timeout
URL: https://github.com/apache/activemq-artemis/pull/2561#discussion_r260320311
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java
##########
@@ -771,7 +771,11 @@ private void reconnectSessions(final RemotingConnection
oldConnection,
((CoreRemotingConnection)
connection).syncIDGeneratorSequence(((CoreRemotingConnection)
oldConnection).getIDGeneratorSequence());
for (ClientSessionInternal session : sessionsToFailover) {
- session.handleFailover(connection, cause);
+ if (session.handleFailover(connection, cause)) {
+ connection.destroy();
Review comment:
I actually confused with this issue.. but yeah.. on both cases.. a test
case... or more detailed information would help.
Think about this: another user is having a similar issue, if you only
provide the fix and not what happened they will never be able to pinpoint this
is the fix they need. for both cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
