On Fri, 10 Jul 2020 at 22:12, Timothy Bish <tabish...@gmail.com> wrote:
>
> On 7/10/20 9:26 AM, Clebert Suconic wrote:
> > I would like to propose an Apache ActiveMQ Artemis 2.14.0 release.
> >
> > We only added one feature as part of this release:
> >
> > [ARTEMIS-2770] - Update diverts using the management API
> >
> > And we have quite a few improvements on this release:
> >
> > [ARTEMIS-2109] - enable building Artemis with JDK 11+
> > [ARTEMIS-2771] - Support JVM GC & thread metrics
> > [ARTEMIS-2776] - Dockerfile improvements to startup arguments
> > [ARTEMIS-2786] - Timestamp in console is incorrect
> > [ARTEMIS-2787] - Allow a queue to be disabled, so that messages are not
> > routed to it.
> > [ARTEMIS-2797] - Reset queue properties by unsetting them in broker.xml
> > [ARTEMIS-2807] - Avoid notifications on critical IO error
> > [ARTEMIS-2820] - Undeploy diverts by removing them from broker.xml
> > [ARTEMIS-2827] - Add addressMemoryUsagePercentage as metric
> > [ARTEMIS-2828] - Add addressSize as metric
> >
> >
> >
> > The whole release notes is here:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12348290&styleName=&projectId=12315920&Create=Create&atl_token=A5KQ-2QAV-T4JA-FDED_4d142d7a703c84c576af5fabc058fb51bb1473f2_lin
> >
> >
> > Source and binary distributions can be found here:
> > https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/2.14.0/
> >
> > The Maven repository is here:
> > https://repository.apache.org/content/repositories/orgapacheactivemq-1214
> >
> > In case you want to give it a try with the maven repo on examples:
> > http://activemq.apache.org/components/artemis/documentation/hacking-guide/validating-releases.html
> >
> >
> > I will update the website after the vote has passed.
> >
> >
> > [ ] +1 approve the release as Apache Artemis 2.4.0
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and reason why)
> +1
>
> * Verified signatures and checksums
> * Checked for license and notice files in archives
> * Verified source license headers with Apache Rat
> * Ran binary broker instance and tested with Qpid JMS examples and
> exercised the web console
> * Built from source and ran some of the tests in the integration test suite.
>
> Should note that I noticed there seems to be an issue in the maven build
> configuration that is preventing specification of test filters at the
> command line like the following: "mvn test -Ptests
> -Dtest=org.apache.activemq.artemis.tests.integration.amqp.*".  It isn't
> clear yet what is breaking but the filters don't seem to be applied
> correctly and no tests are run even though there are tests that match
> this, and this did work in previous releases.
>
> --
> Tim Bish
>

This appears to be due to a Surefire and Failsafe plugin version
update and alignment I did in:
https://github.com/apache/activemq-artemis/commit/515dde9ef3830dc71d48c944d88d2addbc07f799

It seems that newer (but still many years old) Surefire versions dont
match any tests with that particular -Dtest= syntax, incuding the
latest Surefire 3.0.0 milestones, whilst older versions did though
seemingly unexpectedly:
https://issues.apache.org/jira/browse/SUREFIRE-1389

I was able to get it to run the subset of tests by adding various
things to make it further match on the classes within the package, e.g
trying adding a trailing '.' or 'Test' or '.java' to your example
command it then does match and run the tests. It matches in the exact
package in those cases and not in contained sub packages, though I
believe this is the same as the older variant did with prior Surefire
versions.

To get what I think is the probably the more desirable behaviour,
where the tests in a package and its subpackages are run, I found
commands of these styles to work:

mvn test -Dtest=test.package.**
mvn test -Dtest=%regex[test.package.*]

Robbie

Reply via email to