Hey folks,
I don't think that keeping the docker file and supporting code in the same
codebase as ActiveMQ is a good idea. There will be problems managing tags for
releases and docker images in the same repository and you will end up including
fixes for unrelated docker containers in newer releases. The accepted best
practice seems to be a separate repository. Something in the Apache namespace
on GitHub is definitely sufficient to establish the trust that it is the
official docker image or you could pursue creating an official docker image
(https://docs.docker.com/docker-hub/official_images/#creating-an-official-image)
which are hosted in the https://github.com/docker-library namespace and of
course must be separate from the codebase.
Thanks,
Lucas Tétreault
On 2021-02-08, 10:23 AM, "Matt Pavlovich" <mattr...@gmail.com> wrote:
CAUTION: This email originated from outside of the organization. Do not
click links or open attachments unless you can confirm the sender and know the
content is safe.
Got it. I’ll get a PR for an initial activemq-docker module for 5.17.x
pushed out.
Thanks,
-Matt
> On Feb 8, 2021, at 11:25 AM, Jean-Baptiste Onofre <j...@nanthrax.net>
wrote:
>
> Hi Matt,
>
> My preference would be to have a module in the codebase. It would
"secure" the link between docker image and the actual code.
>
> Regards
> JB
>
>> Le 8 févr. 2021 à 17:22, Matt Pavlovich <mattr...@gmail.com> a écrit :
>>
>> JB/Charles-
>>
>> We have some parameterized configs we can pitch in as well. I was
thinking a separate repo would make sense, vs a module within the main tree.
Easier for users to clone and customize.
>>
>> Thoughts?
>> [ ] Separate activemq-docker repo
>> [ ] Add module to main ‘activemq’ tree
>>
>> Thanks!
>> -Matt Pavlovich
>>
>>> On Feb 5, 2021, at 10:45 PM, Jean-Baptiste Onofre <j...@nanthrax.net>
wrote:
>>>
>>> Hi,
>>>
>>> Of course a discussion is always welcome.
>>>
>>> To answer to your first question:
>>>
>>> 1. Alpine is fine IMHO for ActiveMQ (lighter).
>>> 2. Java 8 for ActiveMQ 5.15.x, Java 11 based image for ActiveMQ 5.16.x+
>>> 3. The ActiveMQ Jira is there:
https://issues.apache.org/jira/projects/AMQ/issues/AMQ-7229?filter=allopenissues
<https://issues.apache.org/jira/projects/AMQ/issues/AMQ-7229?filter=allopenissues>
>>> I can create a component Docker on Jira.
>>>
>>> IMHO, the docker image should use env variables to pass configuration
(in activemq.xml), and we should provide README.md with some important
information (I’m thinking the filesystem to use on some cloud provider, like
EFS on AWS, etc).
>>> By the way, I also have a Dockerfile for my production system (on Azure
and AWS).
>>>
>>> Regards
>>> JB
>>>
>>>> Le 5 févr. 2021 à 21:45, Shank, Charles R <shan...@nationwide.com> a
écrit :
>>>>
>>>>
>>>> JB,
>>>>
>>>> The dockerfile and image that we currently have available is specific
to Nationwide. What I would like to propose is to have a community discussion
on the requirements so a generic docker image could be created that would
benefit the whole ActiveMQ community.
>>>>
>>>> For example:
>>>> Do we build it using Debian or alpine?
>>>> Java version?
>>>> Items like this - also where does the jira board for ActiveMQ reside?
>>>>
>>>> I look forward to working with you and the others in the ActiveMQ
community
>>>>
>>>> Thank you in advance
>>>> Chuck Shank
>>>>
>>>>
>>>>
>>>> -----Original Message-----
>>>> From: Jean-Baptiste Onofre <j...@nanthrax.net>
>>>> Sent: Friday, February 05, 2021 11:55 AM
>>>> To: dev@activemq.apache.org
>>>> Subject: [EXTERNAL] Re: [ANN] Apache ActiveMQ 5.16.1 has been released!
>>>>
>>>> Nationwide Information Security Warning: This is an EXTERNAL email.
Use CAUTION before clicking on links, opening attachments, or responding.
(Sender: dev-return-72165-SHANKC1=nationwide....@activemq.apache.org)
>>>>
>>>>
------------------------------------------------------------------------------
>>>>
>>>>
>>>> Awesome !
>>>>
>>>> Do you already have a Dockerfile ready ?
>>>>
>>>> Regards
>>>> JB
>>>>
>>>>> Le 5 févr. 2021 à 17:52, Shank, Charles R <shan...@nationwide.com> a
écrit :
>>>>>
>>>>> Nationwide would like to be involved in creating a standard image
that could be used by the open source community for ActiveMQ
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> -----Original Message-----
>>>>> From: Jean-Baptiste Onofre <j...@nanthrax.net>
>>>>> Sent: Friday, February 05, 2021 11:49 AM
>>>>> To: dev@activemq.apache.org
>>>>> Subject: [EXTERNAL] Re: [ANN] Apache ActiveMQ 5.16.1 has been
released!
>>>>>
>>>>> Nationwide Information Security Warning: This is an EXTERNAL email.
Use CAUTION before clicking on links, opening attachments, or responding.
(Sender: dev-return-72163-SHANKC1=nationwide....@activemq.apache.org)
>>>>>
>>>>>
------------------------------------------------------------------------------
>>>>>
>>>>>
>>>>> Hi,
>>>>>
>>>>> We don’t have "official" Apache image
(https://hub.docker.com/r/apache/activemq
<https://hub.docker.com/r/apache/activemq>).
>>>>>
>>>>> I create such image for Apache Karaf
(https://hub.docker.com/r/apache/karaf <https://hub.docker.com/r/apache/karaf>).
>>>>>
>>>>> Maybe we can create a Jira about that and start something about that.
>>>>>
>>>>> Thoughts ?
>>>>>
>>>>> Regards
>>>>> JB
>>>>>
>>>>>> Le 5 févr. 2021 à 17:45, Shank, Charles R <shan...@nationwide.com> a
écrit :
>>>>>>
>>>>>> Good morning, I appreciate the emails I have been receiving - I
would like to know if there is a standard docker image of ActiveMQ that is used
by the AMQ community that is used in a kubernetes container?
>>>>>>
>>>>>> Thank you
>>>>>> Chuck Shank
>>>>>> Nationwide Insurance
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Jean-Baptiste Onofre <j...@nanthrax.net>
>>>>>> Sent: Friday, February 05, 2021 11:38 AM
>>>>>> To: dev@activemq.apache.org; u...@activemq.apache.org
>>>>>> Cc: annou...@apache.org
>>>>>> Subject: [EXTERNAL] [ANN] Apache ActiveMQ 5.16.1 has been released!
>>>>>>
>>>>>> Nationwide Information Security Warning: This is an EXTERNAL email.
Use CAUTION before clicking on links, opening attachments, or responding.
(Sender: dev-return-72161-SHANKC1=nationwide....@activemq.apache.org)
>>>>>>
>>>>>>
------------------------------------------------------------------------------
>>>>>>
>>>>>>
>>>>>> Hi everyone,
>>>>>>
>>>>>> The ActiveMQ team is pleased to announce Apache ActiveMQ 5.16.1
release.
>>>>>>
>>>>>> http://activemq.apache.org/activemq-5161-release
<http://activemq.apache.org/activemq-5161-release>
>>>>>>
>>>>>> This release includes updates, and improvements, especially:
>>>>>>
>>>>>> - Fix on the runtime configuration plugin, allowing to work with
both JDK8 and JDK9+
>>>>>> - Prefetch & invalid certificate warnings now include details about
the client
>>>>>> - bunch of dependency updates, addressing third party fixes and CVE
>>>>>> - new simple logout link on admin console
>>>>>> - improved Apache Karaf features
>>>>>> - and much more !
>>>>>>
>>>>>> Enjoy !
>>>>>>
>>>>>> Regards
>>>>>> —
>>>>>> The ActiveMQ Team
>>>>>
>>>>
>>>
>>
>
