machristie commented on a change in pull request #48:
URL:
https://github.com/apache/airavata-django-portal/pull/48#discussion_r478469994
##########
File path: django_airavata/apps/api/views.py
##########
@@ -184,6 +184,12 @@ def perform_create(self, serializer):
experiment = serializer.save(
gatewayId=self.gateway_id,
userName=self.username)
+ #FIXME: Moving the setting experimentDataDirectory on experiment step
during experiment creation. Check with the team
+ self._set_storage_id_and_data_dir(experiment)
Review comment:
This should mostly be okay. I implemented it so that the experiment data
directory is created at launch time because the user can change the
experiment's name and project after creating the experiment and the experiment
name and project name are used in generating the experiment data directory. So
my thinking was might as well wait until the last moment to create it. But this
is fine too.
However, since the experiment data directory isn't really needed (it's just
used to get the user's directory in the storage resource), maybe there's
another way. I thought why not use the StoragePreference.fileSystemRootLocation
+ the user's username to get the user's directory. Did you consider that
approach?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
