machristie commented on a change in pull request #48:
URL:
https://github.com/apache/airavata-django-portal/pull/48#discussion_r480347450
##########
File path: django_airavata/apps/api/views.py
##########
@@ -184,6 +184,12 @@ def perform_create(self, serializer):
experiment = serializer.save(
gatewayId=self.gateway_id,
userName=self.username)
+ #FIXME: Moving the setting experimentDataDirectory on experiment step
during experiment creation. Check with the team
+ self._set_storage_id_and_data_dir(experiment)
Review comment:
I think if you integrate the check with launchExperiment instead of
createExperiment (which I just now suggested on the other PR), then you don't
need `_set_storage_id_and_data_dir` in `perform_create`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
