vivekshresta commented on a change in pull request #48:
URL:
https://github.com/apache/airavata-django-portal/pull/48#discussion_r478797577
##########
File path: django_airavata/apps/api/views.py
##########
@@ -184,6 +184,12 @@ def perform_create(self, serializer):
experiment = serializer.save(
gatewayId=self.gateway_id,
userName=self.username)
+ #FIXME: Moving the setting experimentDataDirectory on experiment step
during experiment creation. Check with the team
+ self._set_storage_id_and_data_dir(experiment)
Review comment:
Hi @machristie ,
Thanks for reviewing the code.
I did not consider this approach, thanks for letting me know. But if I need
to go with the current approach, the '_set_storage_id_and_data_dir()' API needs
to be called (Please check my latest comments on my Airavata PR). I've posted
most of my findings over there. Please let me know if it makes sense to stick
with the current approach or if I should go with my initial approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
