Hi All, Thanks for the feedback I collected in Confluence and in this community channel!
To move ahead I created a PR as PoC to collect further feedback -> https://github.com/apache/airflow/pull/27063 Please review (and I am happy if we can move ahead on a fast lane of course :-D) Mit freundlichen Grüßen / Best regards Jens Scheffler Deterministik open Loop (XC-DX/ETV5) Robert Bosch GmbH | Hessbruehlstraße 21 | 70565 Stuttgart-Vaihingen | GERMANY | www.bosch.com Tel. +49 711 811-91508 | Mobil +49 160 90417410 | Threema<threema://add/?id=KKTVR3F4> / Threema Work<threemawork://add/?id=KKTVR3F4>: KKTVR3F4 | [email protected]<mailto:[email protected]> Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart, HRB 14000; Aufsichtsratsvorsitzender: Prof. Dr. Stefan Asenkerschbaumer; Geschäftsführung: Dr. Stefan Hartung, Dr. Christian Fischer, Filiz Albrecht, Dr. Markus Forschner, Dr. Markus Heyn, Rolf Najork From: Jarek Potiuk <[email protected]> Sent: Mittwoch, 21. September 2022 20:42 To: [email protected] Cc: Schilling Christian (XC-DX/ETV5) <[email protected]> Subject: Re: [DISCUSS] AIP-50 Trigger DAG UI Extension with Flexible User Form Concept Agree. That might be really nice to have it, and we could solve a long-standing issue with custom connection fields in the very same way. On Wed, Sep 21, 2022 at 8:27 PM Jeambrun Pierre <[email protected]<mailto:[email protected]>> wrote: Loving Ash idea, param schema seems to have everything we need on top of making this change much easier to implement. Pierre Le mer. 21 sept. 2022 à 12:42, Ash Berlin-Taylor <[email protected]<mailto:[email protected]>> a écrit : Hey Jens, Nice idea. I've left a comment on the AIP page, suggesting that we use the existing DAG param typying (which is built on top of JSON schema) -- to me it has a number of advtanges a) easier to secure (declarative, rather than executing code) which is a good goal as it means it can work with the multi-tenancy AIP work going on. b) It's a much smaller change, all we'd need is the converstion from JSON schema to UI elements c) It's small to the point of not even needing an AIP to achive There's a bit more detail and a few examples in my comment on the AIP. On Sep 18 2022, at 9:52 pm, Scheffler Jens (XC-DX/ETV5) <[email protected]<mailto:[email protected]>> wrote: Hi Airflow-Community, After raising Github issue 26215<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fairflow%2Fissues%2F26215&data=05%7C01%7CJens.Scheffler%40de.bosch.com%7C7d3025ddb2994a0fcba808da9c011259%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C637993825679163259%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MPmmkSFA8kLcrX%2B7go6dYZeo3%2FM9Xro674Bb6qE8cMA%3D&reserved=0> I received and created a new AIP-50<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FAIRFLOW%2FAIP-50%2BTrigger%2BDAG%2BUI%2BExtension%2Bwith%2BFlexible%2BUser%2BForm%2BConcept&data=05%7C01%7CJens.Scheffler%40de.bosch.com%7C7d3025ddb2994a0fcba808da9c011259%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C637993825679163259%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=l1B2UAUB4VHLHsvWi46bJD4YDI9fNxmrnRE9eZLsj4A%3D&reserved=0> I’d like to follow-up to start a discussion via the devlist about a user form proposal. We are actively using such kind of feature and see that probably others also will have a demand for this. So far we have implemented such kind of extension as an Airflow Plugin. https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-50+Trigger+DAG+UI+Extension+with+Flexible+User+Form+Concept<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FAIRFLOW%2FAIP-50%2BTrigger%2BDAG%2BUI%2BExtension%2Bwith%2BFlexible%2BUser%2BForm%2BConcept&data=05%7C01%7CJens.Scheffler%40de.bosch.com%7C7d3025ddb2994a0fcba808da9c011259%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C637993825679163259%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=l1B2UAUB4VHLHsvWi46bJD4YDI9fNxmrnRE9eZLsj4A%3D&reserved=0> What we want to propose and also offer to contribute is an UI extension such that users creating a DAG can add custom trigger forms which improve user experience over the current option to enter a JSON dict. We know that current parallel activity of AIP-38 is ongoing so we understand that we don’t want to extensively elaborate on the existing UI while there are efforts on migration ongoing. We’d love your feedback and nothing is written in stone. Also we could offer a small PoC PR and of course also discuss alternatives and compromises. Mit freundlichen Grüßen / Best regards Jens Scheffler Deterministik open Loop (XC-DX/ETV5) Robert Bosch GmbH | Hessbruehlstraße 21 | 70565 Stuttgart-Vaihingen | GERMANY | www.bosch.com<http://www.bosch.com> Tel. +49 711 811-91508 | Mobil +49 160 90417410 | Threema / Threema Work: KKTVR3F4 | [email protected]<mailto:[email protected]> Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart, HRB 14000; Aufsichtsratsvorsitzender: Prof. Dr. Stefan Asenkerschbaumer; Geschäftsführung: Dr. Stefan Hartung, Dr. Christian Fischer, Filiz Albrecht, Dr. Markus Forschner, Dr. Markus Heyn, Rolf Najork
