Sure :) On Wed, Jul 24, 2024 at 6:09 PM Utkarsh Sharma <utkarsh.sha...@astronomer.io> wrote:
> Hey @Jarek Potiuk <ja...@potiuk.com>, I started with the Python Client > 2.9.1 release, before seeing a couple of last emails, but since I already > have your approval on one of the PR for the 2.9.1 release, I'm considering > it as a go-ahead. :) > > Thanks, > Utkarsh Sharma > > On Wed, Jul 24, 2024 at 7:41 PM Jarek Potiuk <ja...@potiuk.com> wrote: > >> The only problem is that IF we ever go to do a real 2.9.3rc1 (which is >> highly unlikely as Elad mentioned) we will have to release it as rc2 >> because even if the release is deleted, we are not able to upload it again >> due to PyPI immutability of released packages. It's basically "write once >> only". >> >> J, >> >> On Wed, Jul 24, 2024 at 4:05 PM Jarek Potiuk <ja...@potiuk.com> wrote: >> >> > No issue. `dev` in SVN is ***whatever***. I think we should also delete >> > (not yank this time!) it from PyPI because otherwise it will be visible >> in >> > the history as "later" than the 2.9.1 we are going to release and that >> will >> > be even more confusing. >> > >> > J. >> > >> > >> > On Wed, Jul 24, 2024 at 2:51 PM Ephraim Anierobi < >> > ephraimanier...@apache.org> wrote: >> > >> >> Let's go with cutting 2.9.1rc1 and yanking 2.9.3rc1. We had this kind >> of >> >> jump in 2.7.2 when we moved from 2.7.0 to 2.7.2 without 2.7.1, though >> we >> >> hadn't discussed the client versioning being independent of Airflow >> then. >> >> It was a mistake on our part to cut it as 2.9.3rc1, and I think it's >> not >> >> too late to correct it, though we already have artifacts in SVN. If >> >> there's >> >> no issue in removing it from SVN, then we should correct this mistake. >> >> >> >> On Wed, 24 Jul 2024 at 12:37, Jarek Potiuk <ja...@potiuk.com> wrote: >> >> >> >> > Possibly - but also there is no harm in leaving 2.9.3. There is no >> >> formal / >> >> > particular requirement that the version bumps are sequential. >> >> > Pragmatically speaking - it will **just work** for everyone - if >> maybe a >> >> > little confusing why the jump. >> >> > But I am ok with both approaches if we want to do it "properly". >> >> > >> >> > On Wed, Jul 24, 2024 at 1:15 PM Elad Kalif <elad...@apache.org> >> wrote: >> >> > >> >> > > We can ignore + yank 2.9.3rc1 and cut 2.9.1rc1 >> >> > > Since the next airflow release is 2.10 which also includes features >> >> for >> >> > the >> >> > > python client it means the next version for python client is 2.10.0 >> >> > > so we won't need 2.9.3rc1 in the future. >> >> > > >> >> > > On Wed, Jul 24, 2024 at 2:10 PM Jarek Potiuk <ja...@potiuk.com> >> >> wrote: >> >> > > >> >> > > > I think it's a good idea. From what I see it's describe but very >> >> > vaguely: >> >> > > > >> >> > > > "The client versioning is independent of the Airflow >> versioning.". >> >> But >> >> > > > there is more in the Airflow release docs: >> >> > > > https://github.com/apache/airflow/pull/35628 - is the last >> change >> >> from >> >> > > > Pierre about it - so maybe moving this documentation to client >> >> release >> >> > > > notes from Airlfow release notes and linking to that might be a >> good >> >> > idea >> >> > > > (this is likely you missed it). >> >> > > > >> >> > > > J. >> >> > > > >> >> > > > >> >> > > > On Wed, Jul 24, 2024 at 12:55 PM Utkarsh Sharma >> >> > > > <utkarsh.sha...@astronomer.io.invalid> wrote: >> >> > > > >> >> > > > > Hey Jarek, >> >> > > > > >> >> > > > > Thanks, I didn't know that about that. It was a wrong >> assumption >> >> on >> >> > my >> >> > > > > part. Should we also mention this in the client release docs? >> >> > > > > >> >> > > > > Thanks, >> >> > > > > Utkarsh Sharma >> >> > > > > >> >> > > > > On Wed, Jul 24, 2024 at 4:29 AM Jarek Potiuk <ja...@potiuk.com >> > >> >> > wrote: >> >> > > > > >> >> > > > > > +1 (binding): verified reproducibility, checksum, signatures >> - >> >> > python >> >> > > > > > client is generated so no need to check licences. I ran it in >> >> the >> >> > > > breeze >> >> > > > > > environment against the latest airflow and it passed the >> basic >> >> > > checks. >> >> > > > > > Looks good! >> >> > > > > > >> >> > > > > > One small caveat (Utkarsh you probably did not know that) the >> >> > > numbering >> >> > > > > of >> >> > > > > > python client patchlevel is independent from Airflow - every >> >> time >> >> > we >> >> > > > > > release a bugix for API we just bump the latest patchlevel >> (we >> >> did >> >> > > not >> >> > > > > have >> >> > > > > > API bug fixes in 2.9.1, 2.9.2, so it **SHOULD** be 2.9.1rc1 - >> >> but >> >> > > that >> >> > > > > ship >> >> > > > > > has sailed (Pypi releases are immutable so it's better to >> keep >> >> > > current >> >> > > > > > 2.9.3rc1 and continue with 2.9.2 even if we miss two >> patchlevels >> >> > :). >> >> > > > > > >> >> > > > > > Also we had lazy consensus >> >> > > > > > >> >> https://lists.apache.org/thread/m9jdkq7w38d95jykm0l3cm38pmvkzzl7 >> >> > > that >> >> > > > we >> >> > > > > > will decouple even major version from Airflow - but we have >> not >> >> > > > followed >> >> > > > > > regeneration of client with new generator so I think we might >> >> get >> >> > it >> >> > > > for >> >> > > > > > Airflow 3.... in which case they will still be synchronized >> :). >> >> > > > > > >> >> > > > > > J. >> >> > > > > > >> >> > > > > > On Mon, Jul 22, 2024 at 5:43 PM Utkarsh Sharma >> >> > > > > > <utkarsh.sha...@astronomer.io.invalid> wrote: >> >> > > > > > >> >> > > > > > > Hey fellow Airflowers, >> >> > > > > > > >> >> > > > > > > I have cut the first release candidate for the Apache >> Airflow >> >> > > Python >> >> > > > > > Client >> >> > > > > > > 2.9.3. >> >> > > > > > > This email is calling for a vote on the release, >> >> > > > > > > which will last for 72 hours. Consider this my >> (non-binding) >> >> +1. >> >> > As >> >> > > > I’m >> >> > > > > > not >> >> > > > > > > a member of the PMC, Ephraim >> >> > > > > > > signed the distribution. >> >> > > > > > > >> >> > > > > > > Airflow Client 2.9.3rc1 is available at: >> >> > > > > > > >> >> > > > > >> >> > > >> >> >> https://dist.apache.org/repos/dist/dev/airflow/clients/python/2.9.3rc1/ >> >> > > > > > > >> >> > > > > > > The apache_airflow_client-2.9.3.tar.gz is an sdist release >> >> that >> >> > > > > contains >> >> > > > > > > INSTALL instructions, and also >> >> > > > > > > is the official source release. >> >> > > > > > > >> >> > > > > > > The apache_airflow_client-2.9.3-py3-none-any.whl is a >> binary >> >> > wheel >> >> > > > > > release >> >> > > > > > > that pip can install. >> >> > > > > > > >> >> > > > > > > Those packages do not contain .rc* version as, when >> approved, >> >> > they >> >> > > > will >> >> > > > > > be >> >> > > > > > > released as the final version. >> >> > > > > > > >> >> > > > > > > The rc packages are also available at PyPI (with rc suffix) >> >> and >> >> > you >> >> > > > can >> >> > > > > > > install it with pip as usual: >> >> > > > > > > https://pypi.org/project/apache-airflow-client/2.9.3rc1 >> >> > > > > > > >> >> > > > > > > Public keys are available at: >> >> > > > > > > https://dist.apache.org/repos/dist/release/airflow/KEYS >> >> > > > > > > >> >> > > > > > > Only votes from PMC members are binding, but all members of >> >> the >> >> > > > > community >> >> > > > > > > are encouraged to test the release and vote with >> >> "(non-binding)". >> >> > > > > > > >> >> > > > > > > The test procedure for PMC members is described in: >> >> > > > > > > >> >> > > > > > > >> >> > > > > > >> >> > > > > >> >> > > > >> >> > > >> >> > >> >> >> https://github.com/apache/airflow/blob/main/dev/README_RELEASE_PYTHON_CLIENT.md#verify-the-release-candidate-by-pmc-members >> >> > > > > > > >> >> > > > > > > The test procedure for contributors and members of the >> >> community >> >> > > who >> >> > > > > > would >> >> > > > > > > like to test this RC is described in: >> >> > > > > > > >> >> > > > > > > >> >> > > > > > >> >> > > > > >> >> > > > >> >> > > >> >> > >> >> >> https://github.com/apache/airflow/blob/main/dev/README_RELEASE_PYTHON_CLIENT.md#verify-the-release-candidate-by-contributors >> >> > > > > > > >> >> > > > > > > *Changelog:* >> >> > > > > > > >> >> > > > > > > *Major changes:* >> >> > > > > > > >> >> > > > > > > - Add max_consecutive_failed_dag_runs in API spec >> ([#39830]( >> >> > > > > > > https://github.com/apache/airflow/pull/39830)) >> >> > > > > > > >> >> > > > > > > Cheers, >> >> > > > > > > Utkarsh Sharma >> >> > > > > > > >> >> > > > > > >> >> > > > > >> >> > > > >> >> > > >> >> > >> >> >> > >> >
