Awesome work! Thank you, Jarek and Pavan! - Ephraim
On Sat, 4 Jan 2025 at 13:45, Shahar Epstein <sha...@apache.org> wrote: > Well done Jarek and Pavan! > > Shahar > > On Mon, Dec 30, 2024 at 12:15 AM Jarek Potiuk <ja...@potiuk.com> wrote: > > > Hello here, > > > > TL;DR; I just merged https://github.com/apache/airflow/pull/45266 - > > which implemented a much simplified and nicer workflow for our CI. > > > > Rebase to the latest `main` and you should be good to go. > > > > It (finally) switches o from a workflow we had for years (using pretty > > dangerous from the security point of view `pull_request_target` > workflow) - > > into using Artifacts for sharing images in workflow. This was possible > > thanks to new "artifacts" actions and switching to UV. > > > > The benefit of it is that it is way safer - no more "dangerous workflows" > > and simpler - we have a lot simpler Dockerfile.ci and caching mechanism > > implemented. We worked this out by discussing with other ASF projects and > > actually even reusing an action developed by a fellow Apache Arrow > > committer and PMC member - Jacob Wujciak. > > > > The things everyone should do: > > > > * rebase your PR to latest main to make your PRs rebuilt using the new > > workflow > > * run `breeze ci-image build` if you are using breeze locally > > > > I expect some teething problems, so do not hesitate to raise your > problems > > in #internal-airflow-ci-cd channel for CI or #airflow-breeze channel if > you > > see breeze problems > > > > Your regular workflows should continue working as usual, you should see > > just one workflow in CI running builds and tests instead of two. > > > > J. > > >
