I also secured help of David from pallets foundation - he is the main person behind flask, flask-sqlalchemy, werkzeug and a number of others - I had a call with him last week and he explained me why they are very, very cautious about patching old versions (perfectly understandable) and offered their help with Flask 3 migration of FAB or Airflow when we need it. I met David at Pycon, so it seems that the in-person relations here work well :)
J. Fingers crossed for ending our long time flask-werkzeug delays. On Thu, Jun 26, 2025 at 3:22 PM Vincent Beck <vincb...@apache.org> wrote: > > We already have a gree FAB 5 PR that we keep on rebasing, but some of the > > workarounds we implemented to manage different session handling from > > flask-sqlalchemy cause Daniel also rethink the way how flask-sqlalchemy > is > > integrated, so thanks to our testing and work with Vincent, he is going > to > > try another way of integration - that will be simpler, will drop some > > nice-to-have flask-sqllchemy features (automated casing) in favour of > more > > straightforward session management - which means that we will be able to > > remove our workarounds (fingers crossed) > > Nice! Very good news! Thanks for following-up on this one with Daniel > Jarek. I do not like either the workarounds we implemented :) > > On 2025/06/26 09:25:54 Jarek Potiuk wrote: > > An update about FAB 5. > > > > I had a call with Daniel Gaspar yesterday and the current plans of his > are > > to make FAB 5 release with SQLAlchemy 2 support and (this is new) Flask 3 > > upgrade in the next couple of months. > > > > We already have a gree FAB 5 PR that we keep on rebasing, but some of the > > workarounds we implemented to manage different session handling from > > flask-sqlalchemy cause Daniel also rethink the way how flask-sqlalchemy > is > > integrated, so thanks to our testing and work with Vincent, he is going > to > > try another way of integration - that will be simpler, will drop some > > nice-to-have flask-sqllchemy features (automated casing) in favour of > more > > straightforward session management - which means that we will be able to > > remove our workarounds (fingers crossed) - I offered help from our team > and > > Daniel will keep us in the loop of progress, and we will continue helping > > with testing new alphas/betas/rcs released soon (hopefully). The > SQLAlchemy > > 2 and Flask 3 are also needed by Superset and 2 days ago was the time > when > > Superset 5 big release (sort of like Airflow 3) was released so Daniel > will > > have more time for this work. > > > > There are some cool benefits it will bring - and I am keeping my eyes on > > it. Still - there is the #fab-upgrade channel on Slack > > https://apache-airflow.slack.com/archives/C08SM33PNKS that you can > join if > > you want to help, more info will be posted there and we will work there > > together to help this to happen sooner rather than later. > > > > J > > > > On Mon, May 12, 2025 at 4:09 PM Jarek Potiuk <ja...@potiuk.com> wrote: > > > > > Cool. I will start a small slack group for it :) > > > > > > On Mon, May 12, 2025 at 1:44 PM Vincent Beck <vincb...@apache.org> > wrote: > > > > > >> Hello, > > >> > > >> Just got back from vacations (hence the delay) but I am of course > happy > > >> to help in that effort. Upgrading to FAB 5 will unblock many things. > > >> > > >> On 2025/05/07 09:19:17 Jarek Potiuk wrote: > > >> > Wooohoho :) Moar hands and eyes :) > > >> > > > >> > On Wed, May 7, 2025 at 11:13 AM Ankit Chaurasia < > sunank...@gmail.com> > > >> wrote: > > >> > > > >> > > Hi Jarek, I would like to help with the migration work as well. > > >> > > > > >> > > Regards > > >> > > *Ankit Chaurasia* > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > On Wed, May 7, 2025 at 2:51 PM Jarek Potiuk <ja...@potiuk.com> > wrote: > > >> > > > > >> > > > Fantastic - thanks Ephraim - I might wait for Vincents' ok and > we > > >> can > > >> > > form > > >> > > > a small task force to do it :) > > >> > > > > > >> > > > wt., 6 maj 2025, 13:10 użytkownik Ephraim Anierobi < > > >> > > > ephraimanier...@gmail.com> napisał: > > >> > > > > > >> > > > > Hi Jarek, I can help with the migration > > >> > > > > > > >> > > > > On Tue, 6 May 2025 at 11:02, Avi <a...@astronomer.io.invalid> > > >> wrote: > > >> > > > > > > >> > > > > > I think it is a good time to revisit > > >> > > > > > https://github.com/apache/airflow/issues/28723 > > >> > > > > > - Avi > > >> > > > > > > > >> > > > > > On Tue, May 6, 2025 at 8:17 AM Jarek Potiuk < > ja...@potiuk.com> > > >> > > wrote: > > >> > > > > > > > >> > > > > > > Just copying it from the Slack message - devlist seems to > be > > >> more > > >> > > > > > > appropriate :). > > >> > > > > > > > > >> > > > > > > We got informed by Daniel Gaspar from Superset that he is > > >> gearing > > >> > > for > > >> > > > > > > release of FAB 5.0.0 - and asked us to test a8 release > > >> > > > > > > https://pypi.org/project/Flask-AppBuilder/5.0.0a8/ - > which > > >> should > > >> > > - > > >> > > > in > > >> > > > > > > principle - unblock us from migrating to SQLAlchemy 2. > > >> > > > > > > > > >> > > > > > > I looked at what is needed and we need to do it in two > steps. > > >> > > > > > > > > >> > > > > > > Step 1: Migrate to 4.6.2 version of FAB -> FAB 4.6.2 added > > >> Group > > >> > > > > support > > >> > > > > > > (which generally is something that might be useful for us > as > > >> well - > > >> > > > and > > >> > > > > > > highly requested feature > > >> > > > > > > > > >> > > > > > > Step 2: Test and migrate to SQLAlchemy 2 > > >> > > > > > > > > >> > > > > > > And I think it's best it's done with Vincent and maybe > > >> someone from > > >> > > > > > > Astronomer who knows more about Sqlalchemy and data > migration > > >> than > > >> > > me > > >> > > > > - I > > >> > > > > > > am happy to participate and review, but I do not feel > > >> competent to > > >> > > > > > > implement the changes - I've never added any migration or > > >> > > SQLAlchemy > > >> > > > > > model. > > >> > > > > > > Unfortunately this requires far more than copy & pasting > > >> pieces of > > >> > > > > > > vendored-in FAB security manager. > > >> > > > > > > > > >> > > > > > > Years ago a decision was made that we vendor-in part of > the > > >> code of > > >> > > > > FAB - > > >> > > > > > > and part of it is vendoring in models and migration and we > > >> need to > > >> > > > > follow > > >> > > > > > > that - unfortunately. > > >> > > > > > > It does not seem a lot of work, but I am afraid I only > know > > >> > > > SQLalchemy > > >> > > > > > on a > > >> > > > > > > very surface - there is literally one model (Group) to add > > >> and some > > >> > > > > code > > >> > > > > > to > > >> > > > > > > handle it - including migrations, but also testing the new > > >> group > > >> > > > > feature > > >> > > > > > of > > >> > > > > > > FAB and how it integrates with Airflow is a bit more > complex > > >> than > > >> > > > just > > >> > > > > > "new > > >> > > > > > > FAB version migration". > > >> > > > > > > > > >> > > > > > > I created a small task for it - without too many details - > > >> but I > > >> > > > think > > >> > > > > we > > >> > > > > > > need a small team (I guess Vincent is the most natural > > >> candidate + > > >> > > > > > someone > > >> > > > > > > from Astro about migrations and SQLAlchemy) who could > > >> implement and > > >> > > > > test > > >> > > > > > > this change. I am happy to review, help to make decisions > and > > >> > > discuss > > >> > > > > it > > >> > > > > > > and get the dependencies sorted out. > > >> > > > > > > > > >> > > > > > > https://github.com/apache/airflow/issues/50186 > > >> > > > > > > > > >> > > > > > > One of the things it will unblock finally if we get to > 5.0.0 > > >> is PRs > > >> > > > > like > > >> > > > > > > that https://github.com/apache/airflow/pull/50221 where > we > > >> cannot > > >> > > > bump > > >> > > > > > the > > >> > > > > > > min version of sendgrid because it conflicts with the > infamous > > >> > > > Werkzeug > > >> > > > > > > versions that old FAB depends on. > > >> > > > > > > > > >> > > > > > > WDYT? Can we get a small group of people around that task > to > > >> do it > > >> > > > > > > "properly"? It would be great to have it as a 3.1.0 > > >> deliverable to > > >> > > > > > finally > > >> > > > > > > cut all our ties with the old FAB things. > > >> > > > > > > > > >> > > > > > > J > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> --------------------------------------------------------------------- > > >> To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org > > >> For additional commands, e-mail: dev-h...@airflow.apache.org > > >> > > >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org > For additional commands, e-mail: dev-h...@airflow.apache.org > >
