shahar1 commented on code in PR #55327:
URL: https://github.com/apache/airflow/pull/55327#discussion_r2327650220
##########
dev/i18n/check_translations_completeness.py:
##########
@@ -467,9 +485,9 @@ def cli(language: str | None = None, add_missing: bool =
False):
summary,
)
if not found_difference and not has_todos:
- console.print("[green]All translations are complete and
consistent![/green]")
- if found_difference:
- sys.exit(1)
+ console.print("\n[green]All translations are complete and
consistent![/green]\n\n")
+ else:
+ console.print("\n[red]Some translations are not consistent![/red]\n\n")
Review Comment:
```suggestion
console.print("\n[red]Some translations are not complete nor
consistent![/red]\n\n")
```
Could you please clarify what consistency is in this context? (it's not that
clear)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
