Owen-CH-Leung commented on code in PR #55365: URL: https://github.com/apache/airflow/pull/55365#discussion_r2331231730
########## scripts/ci/docker-compose/integration-elasticsearch.yml: ########## @@ -0,0 +1,48 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +--- +services: + elasticsearch: + image: docker.elastic.co/elasticsearch/elasticsearch:8.19.0 + labels: + breeze.description: "Integration required for Elasticsearch hooks." + environment: + - discovery.type=single-node + - xpack.security.enabled=false + - "ES_JAVA_OPTS=-Xms512m -Xmx512m" + volumes: + - elasticsearch-db-volume:/usr/share/elasticsearch/data + ports: + - "${ELASTICSEARCH_HOST_PORT:-9200}:9200" + - "9300:9300" + healthcheck: + test: ["CMD-SHELL", "curl -f http://localhost:9200/_cluster/health || exit 1"] + interval: 10s + timeout: 30s + start_period: 60s + retries: 50 + restart: "on-failure" + + airflow: + environment: + - INTEGRATION_ELASTICSEARCH=true Review Comment: I think we don't need to set any env variables here becoz the env variables will be respected at `files/airflow-breeze-config/environment_variables.env` ? FYI, the env variables I usually set up when doing development work for ES provider are : ``` AIRFLOW__LOGGING__REMOTE_LOGGING=True AIRFLOW__ELASTICSEARCH__HOST="http://localhost:9200"; AIRFLOW__ELASTICSEARCH__JSON_FORMAT=True AIRFLOW__ELASTICSEARCH__WRITE_TO_ES=True AIRFLOW__ELASTICSEARCH__WRITE_STDOUT=False ``` ########## scripts/ci/docker-compose/integration-elasticsearch.yml: ########## @@ -0,0 +1,48 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +--- +services: + elasticsearch: + image: docker.elastic.co/elasticsearch/elasticsearch:8.19.0 + labels: + breeze.description: "Integration required for Elasticsearch hooks." + environment: + - discovery.type=single-node + - xpack.security.enabled=false + - "ES_JAVA_OPTS=-Xms512m -Xmx512m" + volumes: + - elasticsearch-db-volume:/usr/share/elasticsearch/data + ports: + - "${ELASTICSEARCH_HOST_PORT:-9200}:9200" + - "9300:9300" Review Comment: I think we don't need to expose port 9300 since it's a transport port used in a cluster set up. Only the port 9200 (which is the rest API endpoint) is needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
