Hey Hitesh, > For all the bundled files with different licenses (MIT, BSD, etc), the full texts of these licenses should be in the source tarball preferably at the end of the LICENSE file.
This was done by Bolke as part of https://github.com/apache/incubator-airflow/pull/2250 > webgl-2d needs to be called out as MIT license. This was done by Bolke as part of https://github.com/apache/incubator-airflow/pull/2250 > Version in pkg-info has an rc0 notation. It should just be 1.8.1-incubating. This is a bit tricky to do with Python builds. I don't really want to keep building RCs with the exact same version number. We bake these RCs in real environments, so we need to version them with something that distinguishes one from another. Once we set the version, that propagates into the pkg-info. The plan is to rebuild the final RC that passes without the rc notation, so the release doesn't contain it. > A bunch of files under apache_airflow.egg-info/ and scripts/systemd/ need a license header The egg-info is stuff that's generated during the build phase by the build system (`python sdist`). We don't have control over it, afaik. For systemd, I see that all files in scripts have Apache 2.0 licenses except: modified: scripts/ci/requirements.txt modified: scripts/systemd/airflow I have addressed this here: https://github.com/apache/incubator-airflow/pull/2253 > Likewise for airflow/www/templates/airflow/variables/README.md You want to add a license header to a README? That seems kind of crazy. We don't have a license in our main README. Neither does Kafka, nor Hadoop: https://raw.githubusercontent.com/apache/kafka/trunk/README.md https://github.com/apache/hadoop/blob/trunk/README.txt Cheers, Chris On Thu, Apr 20, 2017 at 10:46 AM, Chris Riccomini <[email protected]> wrote: > NM, figured it out and closed JIRA. Some runaway airflow UI procs were > still running. Killed them and all is better. I suspect during 1.8.1 > upgrade I hard killed supervisor somehow. Oh well. :) > > On Thu, Apr 20, 2017 at 10:35 AM, Chris Riccomini <[email protected]> > wrote: > >> Found another issue: >> >> https://issues.apache.org/jira/browse/AIRFLOW-1132 >> >> Unable to clear DAGs via UI. >> >> On Wed, Apr 19, 2017 at 12:34 PM, siddharth anand <[email protected]> >> wrote: >> >>> https://issues.apache.org/jira/browse/AIRFLOW-1121 is merged to fix the >>> webserver pid issue.. thx Kengo! >>> >>> -s >>> >>> On Tue, Apr 18, 2017 at 6:15 PM, Hitesh Shah <[email protected]> wrote: >>> >>> > -1. >>> > >>> > Not sure if these have been called out earlier. >>> > >>> > For all the bundled files with different licenses (MIT, BSD, etc), the >>> full >>> > texts of these licenses should be in the source tarball preferably at >>> the >>> > end of the LICENSE file. >>> > webgl-2d needs to be called out as MIT license. >>> > Version in pkg-info has an rc0 notation. It should just be >>> > 1.8.1-incubating. >>> > A bunch of files under apache_airflow.egg-info/ and scripts/systemd/ >>> need a >>> > license header >>> > Likewise for airflow/www/templates/airflow/variables/README.md >>> > >>> > Nice to have: >>> > Fix the top-level dir in the tarball to be >>> > "apache-airflow-1.8.1-incubating" instead of >>> > "apache-airflow-1.8.1rc0+apache.incubating" >>> > >>> > For all the other binary files (images, gifs), is there source >>> provenance >>> > for all of them and that all of them are covered by the licenses in the >>> > LICENSE file? >>> > >>> > Last point - are all the entries in the NOTICE file required or do they >>> > just need to be in the LICENSE file? Any additions to the NOTICE have >>> > downstream repercussions as they need to be propagated down by any >>> other >>> > project using airflow. >>> > >>> > thanks >>> > -- Hitesh >>> > >>> > >>> > >>> > On Mon, Apr 17, 2017 at 11:24 AM, Chris Riccomini < >>> [email protected]> >>> > wrote: >>> > >>> > > Dear All, >>> > > >>> > > I have been able to make the Airflow 1.8.1 RC0 available at: >>> > > https://dist.apache.org/repos/dist/dev/incubator/airflow, public >>> keys >>> > are >>> > > available at https://dist.apache.org/repos/ >>> > dist/release/incubator/airflow. >>> > > >>> > > Issues fixed: >>> > > >>> > > [AIRFLOW-1062] DagRun#find returns wrong result if external_trigg >>> > > [AIRFLOW-1054] Fix broken import on test_dag >>> > > [AIRFLOW-1050] Retries ignored - regression >>> > > [AIRFLOW-1033] TypeError: can't compare datetime.datetime to None >>> > > [AIRFLOW-1030] HttpHook error when creating HttpSensor >>> > > [AIRFLOW-1017] get_task_instance should return None instead of th >>> > > [AIRFLOW-1011] Fix bug in BackfillJob._execute() for SubDAGs >>> > > [AIRFLOW-1001] Landing Time shows "unsupported operand type(s) fo >>> > > [AIRFLOW-1000] Rebrand to Apache Airflow instead of Airflow >>> > > [AIRFLOW-989] Clear Task Regression >>> > > [AIRFLOW-974] airflow.util.file mkdir has a race condition >>> > > [AIRFLOW-906] Update Code icon from lightning bolt to file >>> > > [AIRFLOW-858] Configurable database name for DB operators >>> > > [AIRFLOW-853] ssh_execute_operator.py stdout decode default to A >>> > > [AIRFLOW-832] Fix debug server >>> > > [AIRFLOW-817] Trigger dag fails when using CLI + API >>> > > [AIRFLOW-816] Make sure to pull nvd3 from local resources >>> > > [AIRFLOW-815] Add previous/next execution dates to available def >>> > > [AIRFLOW-813] Fix unterminated unit tests in tests.job (tests/jo >>> > > [AIRFLOW-812] Scheduler job terminates when there is no dag file >>> > > [AIRFLOW-806] UI should properly ignore DAG doc when it is None >>> > > [AIRFLOW-794] Consistent access to DAGS_FOLDER and SQL_ALCHEMY_C >>> > > [AIRFLOW-785] ImportError if cgroupspy is not installed >>> > > [AIRFLOW-784] Cannot install with funcsigs > 1.0.0 >>> > > [AIRFLOW-780] The UI no longer shows broken DAGs >>> > > [AIRFLOW-777] dag_is_running is initlialized to True instead of >>> > > [AIRFLOW-719] Skipped operations make DAG finish prematurely >>> > > [AIRFLOW-694] Empty env vars do not overwrite non-empty config v >>> > > [AIRFLOW-139] Executing VACUUM with PostgresOperator >>> > > [AIRFLOW-111] DAG concurrency is not honored >>> > > [AIRFLOW-88] Improve clarity Travis CI reports >>> > > >>> > > I would like to raise a VOTE for releasing 1.8.1 based on release >>> > candidate >>> > > 0, i.e. just renaming release candidate 0 to 1.8.1 release. >>> > > >>> > > Please respond to this email by: >>> > > >>> > > +1,0,-1 with *binding* if you are a PMC member or *non-binding* if >>> you >>> > are >>> > > not. >>> > > >>> > > Vote will run for 72 hours (ends this Thursday). >>> > > >>> > > Thanks! >>> > > Chris >>> > > >>> > > My VOTE: +1 (binding) >>> > > >>> > >>> >> >> >
