I am waiting until incubator actually approves the release. Otherwise, I might have to redo the tag if they reject us and we have to re-vote a new RC.
On Tue, Dec 19, 2017 at 8:19 AM, Bolke de Bruin <[email protected]> wrote: > Chris, > > Can you please tag 1.9.0 correctly (ie 1.9.0)? I see reports on gitter > people have issues with it. > > Cheers, > Bolke. > > > On 18 Dec 2017, at 21:49, Chris Riccomini <[email protected]> wrote: > > > > Thanks to all for helping validate it. :) > > > > On Mon, Dec 18, 2017 at 12:48 PM, Ash Berlin-Taylor < > > [email protected]> wrote: > > > >> Woot! Great news, and thanks for all the time you've spent preparing all > >> the RCs. > >> > >> -ash > >> > >>> On 18 Dec 2017, at 20:13, Chris Riccomini <[email protected]> > wrote: > >>> > >>> Hello, > >>> > >>> Apache Airflow (incubating) 1.9.0 (based on RC8) has been accepted. > >>> > >>> 5 “+1” binding votes received: > >>> > >>> - Maxime Beauchemin (binding) > >>> - Chris Riccomini (binding) > >>> - Bolke de Bruin (binding) > >>> - Joy Gao (binding) > >>> - Fokko Driesprong (binding) > >>> > >>> My next step is to open a thread with the IPMC. > >>> > >>> Cheers, > >>> Chris > >>> > >>> On Mon, Dec 18, 2017 at 11:26 AM, Chris Riccomini < > [email protected] > >>> > >>> wrote: > >>> > >>>> I believe so, yes. > >>>> > >>>> I will proceed with release. :) > >>>> > >>>> On Mon, Dec 18, 2017 at 11:20 AM, Bolke de Bruin <[email protected]> > >>>> wrote: > >>>> > >>>>> But it doesn’t stop us from releasing now right? You can just update > >> the > >>>>> tag. It is not connected to the artifacts. > >>>>> > >>>>> Bolke. > >>>>> > >>>>> Sent from my iPhone > >>>>> > >>>>>> On 18 Dec 2017, at 18:51, Chris Riccomini <[email protected]> > >>>>> wrote: > >>>>>> > >>>>>> https://github.com/apache/incubator-airflow/pull/2889 > >>>>>> > >>>>>> On Mon, Dec 18, 2017 at 9:44 AM, Chris Riccomini < > >> [email protected] > >>>>>> > >>>>>> wrote: > >>>>>> > >>>>>>> Sigh. There's a catch 22 here. If we tag an RC as 1.9.0, we'll have > >> to > >>>>>>> keep editing the tag every time there's a new RC. I agree that > >>>>> removing the > >>>>>>> check seems like the best course of action. > >>>>>>> > >>>>>>> On Sun, Dec 17, 2017 at 12:01 AM, Bolke de Bruin < > [email protected]> > >>>>>>> wrote: > >>>>>>> > >>>>>>>> This is just matter of setting the tag in the repo right? > >>>>>>>> > >>>>>>>> We should remove that check or make it not fail at least. It is > >>>>>>>> ridiculous. > >>>>>>>> > >>>>>>>> B. > >>>>>>>> > >>>>>>>> Verstuurd vanaf mijn iPad > >>>>>>>> > >>>>>>>>> Op 17 dec. 2017 om 07:32 heeft Joy Gao <[email protected]> het > >> volgende > >>>>>>>> geschreven: > >>>>>>>>> > >>>>>>>>> Ahh, tested the build on a fresh virtualenv, which succeeded *the > >>>>> first > >>>>>>>>> time* given gitpython was not installed and it skipped the > >> assertion > >>>>>>>> check > >>>>>>>>> <https://github.com/apache/incubator-airflow/blob/1.9.0rc8/ > >>>>>>>> setup.py#L68-L73>. > >>>>>>>>> Build fails on re-installs :( > >>>>>>>>> > >>>>>>>>>> On Fri, Dec 15, 2017 at 6:01 PM, Feng Lu > >> <[email protected] > >>>>>> > >>>>>>>> wrote: > >>>>>>>>>> > >>>>>>>>>> +0.5 (non-binding) > >>>>>>>>>> > >>>>>>>>>> Looks like the version(1.9.0) and tag(1.9.0rc8) is mismatched, > >>>>>>>>>> <https://github.com/apache/incubator-airflow/blob/1.9.0rc8/ > >>>>>>>> setup.py#L87> > >>>>>>>>>> which will cause the installation (pip install or python setup) > to > >>>>>>>> error > >>>>>>>>>> out and fail. > >>>>>>>>>> nit: mind also updating the release log " > >>>>>>>>>> https://github.com/apache/incubator-airflow/blob/1.9.0rc8/ > >>>>>>>> CHANGELOG.txt" > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> On Fri, Dec 15, 2017 at 3:21 PM, Driesprong, Fokko > >>>>>>>> <[email protected]> > >>>>>>>>>> wrote: > >>>>>>>>>> > >>>>>>>>>>> +1 binding > >>>>>>>>>>> > >>>>>>>>>>> Op vr 15 dec. 2017 om 23:39 schreef Bolke de Bruin < > >>>>> [email protected] > >>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>>> +1, binding > >>>>>>>>>>>> > >>>>>>>>>>>> Checked sigs, version, source is there (did not check build), > >> bin > >>>>> is > >>>>>>>>>>> there. > >>>>>>>>>>>> > >>>>>>>>>>>> Bolke > >>>>>>>>>>>> > >>>>>>>>>>>> Verstuurd vanaf mijn iPad > >>>>>>>>>>>> > >>>>>>>>>>>>> Op 15 dec. 2017 om 23:31 heeft Joy Gao <[email protected]> het > >>>>>>>> volgende > >>>>>>>>>>>> geschreven: > >>>>>>>>>>>>> > >>>>>>>>>>>>> +1, binding > >>>>>>>>>>>>> > >>>>>>>>>>>>> Thank you Chris! > >>>>>>>>>>>>> > >>>>>>>>>>>>> On Fri, Dec 15, 2017 at 2:30 PM, Chris Riccomini < > >>>>>>>>>>> [email protected]> > >>>>>>>>>>>>> wrote: > >>>>>>>>>>>>> > >>>>>>>>>>>>>> Hey all, > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> (Last time, I hope)^2 > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> I have cut Airflow 1.9.0 RC8. This email is calling a vote > on > >>>>> the > >>>>>>>>>>>> release, > >>>>>>>>>>>>>> which will last for 72 hours. Consider this my (binding) +1. > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> Airflow 1.9.0 RC8 is available at: > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> https://dist.apache.org/repos/ > dist/dev/incubator/airflow/1.9 > >>>>> .0rc8/ > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> apache-airflow-1.9.0rc8+incubating-source.tar.gz is a > source > >>>>>>>>>> release > >>>>>>>>>>>> that > >>>>>>>>>>>>>> comes with INSTALL instructions. > >>>>>>>>>>>>>> apache-airflow-1.9.0rc8+incubating-bin.tar.gz is the binary > >>>>> Python > >>>>>>>>>>>> "sdist" > >>>>>>>>>>>>>> release. > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> Public keys are available at: > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> https://dist.apache.org/repos/dist/release/incubator/ > airflow/ > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> The release contains no new JIRAs. Just a version fix. > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> I also had to change the version number to exclude the `rc6` > >>>>> string > >>>>>>>>>> as > >>>>>>>>>>>> well > >>>>>>>>>>>>>> as the "+incubating" string, so it's now simply 1.9.0. This > >> will > >>>>>>>>>> allow > >>>>>>>>>>>> us > >>>>>>>>>>>>>> to rename the artifact without modifying the artifact > >> checksums > >>>>>>>> when > >>>>>>>>>>> we > >>>>>>>>>>>>>> actually release. > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> See JIRAs that were in 1.9.0RC7 and before (see previous > VOTE > >>>>> email > >>>>>>>>>>> for > >>>>>>>>>>>>>> full list). > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> Cheers, > >>>>>>>>>>>>>> Chris > >>>>>>>>>>>>>> > >>>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>> > >>>>>>>> > >>>>>>> > >>>>>>> > >>>>> > >>>> > >>>> > >> > >> > >
