- **status**: in-progress --> review
- **Comment**:

Review at:  **hs/7825**

To QA: Run tests and (ideally) commit to a git/svn/hg repo.

~~~~~~
# from ForgeSVN
nosetests forgesvn.tests.model.test_repository:TestSVNRev --with-progressive
~~~~~~

---

~~~~~~
# from ForgeGit
nosetests forgegit.tests.model.test_repository:TestGitRepo --with-progressive
~~~~~~




---

** [tickets:#7825] Update "new commits" email template**

**Status:** review
**Milestone:** unreleased
**Labels:** ux sf-current sf-2 
**Created:** Wed Feb 04, 2015 04:29 PM UTC by Dave Brondsema
**Last Updated:** Tue May 05, 2015 08:45 PM UTC
**Owner:** Heith Seewald

See attached screenshot for reference.  Several things that can be improved:

* "From" could be improved, e.g. "{{project name}} {{tool name}} repository"
* The branch name is specified in front of just the first commit, and then is 
blank on the rest of the commits.  IIRC this is bad for SVN commit messages too 
since they don't have real branches.  I think it could be better moved up as a 
section header "On `master` branch:".  Test with SVN and with Hg, and with 
commits on multiple branches.
* Markdown formatting in commit messages is not expected, e.g. `__future__` vs 
__future__.  When we render commits, e.g. at 
https://sourceforge.net/p/gazette/code/ci/2cece9731de397e508dfed34d3d6e3866e0a94ac
 we use a special rendering helper that is configured to do some stuff like 
artifact linking but not other markdown formatting.  We should use that for 
these commit emails too.
* It would be cleaner to make the commit message text be a link, instead of 
showing the full link URL in the email text.


---

Sent from forge-allura.apache.org because [email protected] is subscribed 
to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.

Reply via email to