- **status**: review --> in-progress
- **Comment**:
Nice work Heith!
Both code and email layout are definitely cleaner and I like that.
I'd like to see some future improvements, though:
- "From:" header now reads as "Repository Test Project git.git". Can we make it
something like "Test Project Git repository", instead? I.e "{{project_name}}
{{tool_label}} repository"
- Can we make default branch (`app.default_branch_name`) appear first in email,
even when more than one branch is pushed? It is not essential, but convenient.
- Commit summary does not use special helpers for markdown formatting. E.g.
`__future__` converts to bold __future__, but it should not. We should use
`g.markdown_commit.convert(commit.message)` for that.
- Apply datetime formatting to commit date. SVN notifications currently show
milliseconds "By admin1 on 2015-06-03 09:55:35.169000"
- Branch headers for mercurial appear before every commit
- One test fails
https://forge-allura.apache.org/p/allura/pastebin/556ecd936d19cd7ef78f888f
---
** [tickets:#7825] Update "new commits" email template**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** ux sf-current sf-2
**Created:** Wed Feb 04, 2015 04:29 PM UTC by Dave Brondsema
**Last Updated:** Tue Jun 02, 2015 08:09 PM UTC
**Owner:** Heith Seewald
See attached screenshot for reference. Several things that can be improved:
* "From" could be improved, e.g. "{{project name}} {{tool name}} repository"
* The branch name is specified in front of just the first commit, and then is
blank on the rest of the commits. IIRC this is bad for SVN commit messages too
since they don't have real branches. I think it could be better moved up as a
section header "On `master` branch:". Test with SVN and with Hg, and with
commits on multiple branches.
* Markdown formatting in commit messages is not expected, e.g. `__future__` vs
__future__. When we render commits, e.g. at
https://sourceforge.net/p/gazette/code/ci/2cece9731de397e508dfed34d3d6e3866e0a94ac
we use a special rendering helper that is configured to do some stuff like
artifact linking but not other markdown formatting. We should use that for
these commit emails too.
* It would be cleaner to make the commit message text be a link, instead of
showing the full link URL in the email text.
---
Sent from forge-allura.apache.org because [email protected] is subscribed
to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
