See attachment for reference
- "From" should be "{{project name}} {{tool name}} repository" as specified in
ticket description
- Link to a user profile is invalid, because of the space. I think it also
affects userpic. In fact, name in commit can be different from Allura username
(as in this example, I use my full name, so link to /u/Igor Bondarenko is
invalid even if spaces will be handled properly).
- Summary does not use artifact linking ([#1] shoud lilnk to ticket as in
commit history view)
- Branch is specified for each first commit in the branch. I think approach
described in ticket description (making branch name header level and then
listing commits after). It's really just my preference, I don't sure what would
work better.
- It would also be good if summary where more visible, right now it's kinda
lost in other headers and has smaller font. I think it should be easier for the
eye to spot summaries instantly within an email.
- Some tests are failing (see below)
I didn't check SVN yet.
~~~~~
======================================================================
FAIL: forgegit.tests.functional.test_controllers.TestRootController.test_refresh
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/var/local/env-allura/lib/python2.7/site-packages/nose-1.3.4-py2.7.egg/nose/case.py",
line 197, in runTest
self.test(*self.arg)
File
"/home/ibondarenko/ibondarenko-1154/forge/ForgeGit/forgegit/tests/functional/test_controllers.py",
line 270, in test_refresh
assert notification
AssertionError:
======================================================================
ERROR: test_refresh (forgesvn.tests.model.test_repository.TestRepo)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/home/ibondarenko/ibondarenko-1154/forge/ForgeSVN/forgesvn/tests/model/test_repository.py",
line 878, in test_refresh
self.repo.refresh()
File
"/home/ibondarenko/ibondarenko-1154/forge/Allura/allura/model/repository.py",
line 650, in refresh
refresh_repo(self, all_commits, notify, new_clone)
File
"/home/ibondarenko/ibondarenko-1154/forge/Allura/allura/model/repo_refresh.py",
line 158, in refresh_repo
send_notifications(repo, commit_ids)
File
"/home/ibondarenko/ibondarenko-1154/forge/Allura/allura/model/repo_refresh.py",
line 412, in send_notifications
short_date=ci.authored.date.strftime('%c')
AttributeError: 'NoneType' object has no attribute 'strftime'
~~~~~
Attachment: commits-email.png (59.9 kB; image/png)
---
** [tickets:#7825] Update "new commits" email template**
**Status:** review
**Milestone:** unreleased
**Labels:** ux sf-current sf-2
**Created:** Wed Feb 04, 2015 04:29 PM UTC by Dave Brondsema
**Last Updated:** Wed May 27, 2015 12:01 PM UTC
**Owner:** Heith Seewald
See attached screenshot for reference. Several things that can be improved:
* "From" could be improved, e.g. "{{project name}} {{tool name}} repository"
* The branch name is specified in front of just the first commit, and then is
blank on the rest of the commits. IIRC this is bad for SVN commit messages too
since they don't have real branches. I think it could be better moved up as a
section header "On `master` branch:". Test with SVN and with Hg, and with
commits on multiple branches.
* Markdown formatting in commit messages is not expected, e.g. `__future__` vs
__future__. When we render commits, e.g. at
https://sourceforge.net/p/gazette/code/ci/2cece9731de397e508dfed34d3d6e3866e0a94ac
we use a special rendering helper that is configured to do some stuff like
artifact linking but not other markdown formatting. We should use that for
these commit emails too.
* It would be cleaner to make the commit message text be a link, instead of
showing the full link URL in the email text.
---
Sent from forge-allura.apache.org because [email protected] is subscribed
to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
