- **status**: review --> in-progress
- **Comment**:
Good job!
For sorting branches this might help:
`Allura/allura/model/repo_refresh.py:_group_commits`. It groups commits by
branch and by tag, so then you can render all the commits that correspond to
default branch first. It should be moved to the `utils.py`, if we end up using
it in some other place.
It can be hard to understand mercurial branching model after git, been there.
I'm not sure my understanding is full also :)
Branch in mercurial is attribute of every commit. It's not like git when branch
is just a pointer to some commit. So,
`branches=repo.symbolics_for_commit(ci)[0],` line always returns branches for
hg, whereas for git it returns branches only for the top commit of some
branch(es). As a workaround we can keep track of branches of previous commit
and if that's equal to current, just return empty list. I guess
`_group_commits` mentioned above might help here as well.
Could you try this? If this turns out time consuming I'm ok with closing this
as is (it is already good enough, especially for git and svn) and creating
followup tickets for those issues.
---
** [tickets:#7825] Update "new commits" email template**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** ux sf-current sf-2
**Created:** Wed Feb 04, 2015 04:29 PM UTC by Dave Brondsema
**Last Updated:** Thu Jun 04, 2015 05:40 AM UTC
**Owner:** Heith Seewald
See attached screenshot for reference. Several things that can be improved:
* "From" could be improved, e.g. "{{project name}} {{tool name}} repository"
* The branch name is specified in front of just the first commit, and then is
blank on the rest of the commits. IIRC this is bad for SVN commit messages too
since they don't have real branches. I think it could be better moved up as a
section header "On `master` branch:". Test with SVN and with Hg, and with
commits on multiple branches.
* Markdown formatting in commit messages is not expected, e.g. `__future__` vs
__future__. When we render commits, e.g. at
https://sourceforge.net/p/gazette/code/ci/2cece9731de397e508dfed34d3d6e3866e0a94ac
we use a special rendering helper that is configured to do some stuff like
artifact linking but not other markdown formatting. We should use that for
these commit emails too.
* It would be cleaner to make the commit message text be a link, instead of
showing the full link URL in the email text.
---
Sent from forge-allura.apache.org because [email protected] is subscribed
to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
