> On Dec. 1, 2014, 11:47 a.m., Robert Nettleton wrote: > > ambari-server/pom.xml, line 1389 > > <https://reviews.apache.org/r/28491/diff/1/?file=777044#file777044line1389> > > > > Since this dependency is also added to the ambari-project pom.xml, > > adding it here should not be necessary. The ambari-server pom.xml should > > just pull it in from it's parent pom.xml. > > > > I'd recommend removing it from here.
The declaration of this dependency in the parent is in the <dependencyManagement> block, not the <depencendy> block, therefore to get the ambari-server project to pull it in this line is needed. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28491/#review63371 ----------------------------------------------------------- On Nov. 26, 2014, 7:19 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28491/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2014, 7:19 p.m.) > > > Review request for Ambari, dilli dorai, Jaimin Jetly, Jonathan Hurley, Nate > Cole, Robert Nettleton, and Tom Beerbower. > > > Bugs: AMBARI-8454 > https://issues.apache.org/jira/browse/AMBARI-8454 > > > Repository: ambari > > > Description > ------- > > Create server-side actions to generate the Kerberos principals and keytabs. > These actions will be used when setting up Kerberos for services when > Kerberizing a cluster. > > > Diffs > ----- > > ambari-project/pom.xml edba1dc > ambari-server/pom.xml e03b626 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCType.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFile.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileBuilder.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileReader.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosCredential.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/28491/diff/ > > > Testing > ------- > > Added new unit tests: > > Running > org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerTest > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.676 sec > Running > org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileTest > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.12 sec > Running > org.apache.ambari.server.serveraction.kerberos.KerberosServerActionTest > Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.465 sec > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 25:36.295s > [INFO] Finished at: Wed Nov 26 18:05:30 EST 2014 > [INFO] Final Memory: 43M/739M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Robert Levas > >
