> On Dec. 1, 2014, 11:03 a.m., Tom Beerbower wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java, > > line 330 > > <https://reviews.apache.org/r/28491/diff/1/?file=777054#file777054line330> > > > > Is it required that the interface force a ConcurrentMap or could this > > be simply Map<String, Object>?
Changed this in revision 2 of the patch. > On Dec. 1, 2014, 11:03 a.m., Tom Beerbower wrote: > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java, > > line 28 > > <https://reviews.apache.org/r/28491/diff/1/?file=777056#file777056line28> > > > > Minor : import not needed since you fully qualify each assertion (i.e. > > Assert.assertNotNull(file)) Fixed in revision 2 of the patch > On Dec. 1, 2014, 11:03 a.m., Tom Beerbower wrote: > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java, > > lines 22-37 > > <https://reviews.apache.org/r/28491/diff/1/?file=777057#file777057line22> > > > > Minor : Optimize the imports. Fixed in revision 2 of the patch - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28491/#review63372 ----------------------------------------------------------- On Dec. 2, 2014, 6:20 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28491/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2014, 6:20 a.m.) > > > Review request for Ambari, dilli dorai, Jaimin Jetly, Jonathan Hurley, Nate > Cole, Robert Nettleton, and Tom Beerbower. > > > Bugs: AMBARI-8454 > https://issues.apache.org/jira/browse/AMBARI-8454 > > > Repository: ambari > > > Description > ------- > > Create server-side actions to generate the Kerberos principals and keytabs. > These actions will be used when setting up Kerberos for services when > Kerberizing a cluster. > > > Diffs > ----- > > ambari-project/pom.xml edba1dc > ambari-server/pom.xml e03b626 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCType.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFile.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileBuilder.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileReader.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosCredential.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractKerberosOperationHandlerTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/28491/diff/ > > > Testing > ------- > > Added new unit tests: > > Running > org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerTest > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.676 sec > Running > org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileTest > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.12 sec > Running > org.apache.ambari.server.serveraction.kerberos.KerberosServerActionTest > Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.465 sec > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 25:36.295s > [INFO] Finished at: Wed Nov 26 18:05:30 EST 2014 > [INFO] Final Memory: 43M/739M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Robert Levas > >
