----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28491/#review63965 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java <https://reviews.apache.org/r/28491/#comment106329> We would need deleteServicePrincipal() method as well. But, this could be added in next phase. ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java <https://reviews.apache.org/r/28491/#comment106340> Noted the change here to process all records with one instance of handler and closing the handler in finally block. Looks good. - dilli dorai On Dec. 5, 2014, 4:38 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28491/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 4:38 a.m.) > > > Review request for Ambari, dilli dorai, Jaimin Jetly, Jonathan Hurley, Nate > Cole, Robert Nettleton, and Tom Beerbower. > > > Bugs: AMBARI-8454 > https://issues.apache.org/jira/browse/AMBARI-8454 > > > Repository: ambari > > > Description > ------- > > Create server-side actions to generate the Kerberos principals and keytabs. > These actions will be used when setting up Kerberos for services when > Kerberizing a cluster. > > > Diffs > ----- > > ambari-project/pom.xml edba1dc > ambari-server/pom.xml 4076d73 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCType.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFile.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileBuilder.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileReader.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosCredential.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerFactory.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/AbstractKerberosOperationHandlerTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/28491/diff/ > > > Testing > ------- > > Added new unit tests: > > Running > org.apache.ambari.server.serveraction.kerberos.KerberosOperationHandlerTest > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.676 sec > Running > org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileTest > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.12 sec > Running > org.apache.ambari.server.serveraction.kerberos.KerberosServerActionTest > Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.465 sec > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 25:36.295s > [INFO] Finished at: Wed Nov 26 18:05:30 EST 2014 > [INFO] Final Memory: 43M/739M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Robert Levas > >
