----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30468/#review70442 -----------------------------------------------------------
ambari-server/src/main/python/setupAgent.py <https://reviews.apache.org/r/30468/#comment115638> We should validate all these changes on both Centos6 and Centos5 :) ambari-server/src/main/python/setupAgent.py <https://reviews.apache.org/r/30468/#comment115635> For consistency, on error this function should adhere to the error return message of other functions. i.e. return {"exitstatus": agent_retcode, "log": log} Same goes for other functions. ambari-server/src/main/python/setupAgent.py <https://reviews.apache.org/r/30468/#comment115637> detecting verbose support should be refactored out of tryStopAgent. That way we can set verbosity independent of stopping the agent. ambari-server/src/main/python/setupAgent.py <https://reviews.apache.org/r/30468/#comment115627> It is odd that we are calling tryStopAgent() before parseArguments(). i.e. if incorrect/invalid args are passed we would end up stopping the agent and exiting with invalid arg exception. ambari-server/src/main/python/setupAgent.py <https://reviews.apache.org/r/30468/#comment115634> When exitcode is not 0 we should log the exitstatus and error log. - Jayush Luniya On Jan. 30, 2015, 10:50 p.m., Florian Barca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30468/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2015, 10:50 p.m.) > > > Review request for Ambari, Dmytro Sen, Jayush Luniya, and Mahadev Konar. > > > Bugs: AMBARI-9341 > https://issues.apache.org/jira/browse/AMBARI-9341 > > > Repository: ambari > > > Description > ------- > > sys.exit() should never be braced in a try/except. The behavior changed in > Python 2.5. See the doc. > > > Diffs > ----- > > ambari-server/src/main/python/setupAgent.py > b2c2d255278d803a7fde71056500688ef85a7d68 > > Diff: https://reviews.apache.org/r/30468/diff/ > > > Testing > ------- > > Bootstrap in a local CentOS 5 cluster. > > > Thanks, > > Florian Barca > >
