> On Jan. 30, 2015, 11:38 p.m., Jayush Luniya wrote: > > ambari-server/src/main/python/setupAgent.py, line 245 > > <https://reviews.apache.org/r/30468/diff/1/?file=842719#file842719line245> > > > > It is odd that we are calling tryStopAgent() before parseArguments(). > > i.e. if incorrect/invalid args are passed we would end up stopping the > > agent and exiting with invalid arg exception.
Yes, this is another consistency issue which will be addressed by a follow-up JIRA item. > On Jan. 30, 2015, 11:38 p.m., Jayush Luniya wrote: > > ambari-server/src/main/python/setupAgent.py, line 92 > > <https://reviews.apache.org/r/30468/diff/1/?file=842719#file842719line92> > > > > detecting verbose support should be refactored out of tryStopAgent. > > That way we can set verbosity independent of stopping the agent. Subject to follow-up. - Florian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30468/#review70442 ----------------------------------------------------------- On Feb. 3, 2015, 7:11 p.m., Florian Barca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30468/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 7:11 p.m.) > > > Review request for Ambari, Dmytro Sen, Jayush Luniya, and Mahadev Konar. > > > Bugs: AMBARI-9341 > https://issues.apache.org/jira/browse/AMBARI-9341 > > > Repository: ambari > > > Description > ------- > > sys.exit() should never be braced in a try/except. The behavior changed in > Python 2.5. See the doc. > > > Diffs > ----- > > ambari-server/src/main/python/setupAgent.py > b2c2d255278d803a7fde71056500688ef85a7d68 > ambari-server/src/test/python/TestSetupAgent.py > 249ce0b15828f5508f072573dae26158b1b0470b > > Diff: https://reviews.apache.org/r/30468/diff/ > > > Testing > ------- > > Bootstrap in a local CentOS 5 cluster. > > > Thanks, > > Florian Barca > >
