----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30468/#review70840 -----------------------------------------------------------
Ship it! Ship It! - Jayush Luniya On Feb. 3, 2015, 10:38 p.m., Florian Barca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30468/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 10:38 p.m.) > > > Review request for Ambari, Dmytro Sen, Jayush Luniya, and Mahadev Konar. > > > Bugs: AMBARI-9341 > https://issues.apache.org/jira/browse/AMBARI-9341 > > > Repository: ambari > > > Description > ------- > > sys.exit() should never be braced in a try/except. The behavior changed in > Python 2.5. See the doc. > > > Diffs > ----- > > ambari-server/src/main/python/setupAgent.py > b2c2d255278d803a7fde71056500688ef85a7d68 > ambari-server/src/test/python/TestSetupAgent.py > 249ce0b15828f5508f072573dae26158b1b0470b > > Diff: https://reviews.apache.org/r/30468/diff/ > > > Testing > ------- > > Bootstrap in a local CentOS 5 cluster. > > > Thanks, > > Florian Barca > >
