----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30568/#review71797 -----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/script/script.py <https://reviews.apache.org/r/30568/#comment117658> I do not like this place as it's a duplication of code from params.py. The correct solution would be to create parent params.py on stack level, which would expose common for every component variables, but I do not want to take this responsibility on myself as I'm not that familiar with python code. I can make a separate jira if needed. Anyway, this implementation is safer and, I think, better than previous "import params". - Yurii Shylov On Фев. 10, 2015, 4:22 п.п., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30568/ > ----------------------------------------------------------- > > (Updated Фев. 10, 2015, 4:22 п.п.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate > Cole. > > > Bugs: AMBARI-9054 > https://issues.apache.org/jira/browse/AMBARI-9054 > > > Repository: ambari > > > Description > ------- > > During the upgrade process, populate the repo_version, cluster_version, and > host_version tables. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 683397a > > ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java > a71bbd1 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 80ef542 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java > 4fe219c > > Diff: https://reviews.apache.org/r/30568/diff/ > > > Testing > ------- > > Manual testing done, UT in progress > > > Thanks, > > Yurii Shylov > >
