> On Feb. 10, 2015, 12:57 p.m., Nate Cole wrote: > > ambari-common/src/main/python/resource_management/libraries/script/script.py, > > line 124 > > <https://reviews.apache.org/r/30568/diff/4/?file=860030#file860030line124> > > > > It's ok to move this import to the top with the others. > > Yurii Shylov wrote: > default.py imports script.py and it causes circular dependency, python > throws error
Wow that's pathetic. Ok :) - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30568/#review71812 ----------------------------------------------------------- On Feb. 10, 2015, 12:47 p.m., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30568/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2015, 12:47 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate > Cole. > > > Bugs: AMBARI-9054 > https://issues.apache.org/jira/browse/AMBARI-9054 > > > Repository: ambari > > > Description > ------- > > During the upgrade process, populate the repo_version, cluster_version, and > host_version tables. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 683397a > > ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java > a71bbd1 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 80ef542 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java > 4fe219c > > Diff: https://reviews.apache.org/r/30568/diff/ > > > Testing > ------- > > Manual testing done, UT passing > > > Thanks, > > Yurii Shylov > >
