----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30568/#review71821 -----------------------------------------------------------
Ship it! ambari-common/src/main/python/resource_management/libraries/script/script.py <https://reviews.apache.org/r/30568/#comment117689> Should perhaps add an else block to return False for the case where command_name is "status" since there's no need to execute line 151. - Alejandro Fernandez On Feb. 10, 2015, 5:47 p.m., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30568/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2015, 5:47 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate > Cole. > > > Bugs: AMBARI-9054 > https://issues.apache.org/jira/browse/AMBARI-9054 > > > Repository: ambari > > > Description > ------- > > During the upgrade process, populate the repo_version, cluster_version, and > host_version tables. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 683397a > > ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java > a71bbd1 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 80ef542 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java > 4fe219c > > Diff: https://reviews.apache.org/r/30568/diff/ > > > Testing > ------- > > Manual testing done, UT passing > > > Thanks, > > Yurii Shylov > >
