> On Березень 26, 2015, 6:25 після полудня, Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, > > line 189 > > <https://reviews.apache.org/r/32540/diff/1/?file=906765#file906765line189> > > > > Can you add a unit test?
fixed > On Березень 26, 2015, 6:25 після полудня, Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, > > line 995 > > <https://reviews.apache.org/r/32540/diff/1/?file=906765#file906765line995> > > > > Use StringUtils.isEmpty fixed > On Березень 26, 2015, 6:25 після полудня, Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, > > line 1041 > > <https://reviews.apache.org/r/32540/diff/1/?file=906765#file906765line1041> > > > > Can we rename "isStateVerified" to "checkState"? fixed - Vitalyi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32540/#review77922 ----------------------------------------------------------- On Березень 26, 2015, 6:12 після полудня, Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32540/ > ----------------------------------------------------------- > > (Updated Березень 26, 2015, 6:12 після полудня) > > > Review request for Ambari, Dmytro Sen, John Speidel, and Sumit Mohanty. > > > Bugs: AMBARI-4782 > https://issues.apache.org/jira/browse/AMBARI-4782 > > > Repository: ambari > > > Description > ------- > > . > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > a3ede22 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java > 6536bd5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java > 639e170 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java > 0e10e79 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java > 9bc7570 > > Diff: https://reviews.apache.org/r/32540/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
