----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32540/#review78939 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java <https://reviews.apache.org/r/32540/#comment128049> Is anyone using getRequest(Map<String, Object>) call? ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java <https://reviews.apache.org/r/32540/#comment128050> Can you add some explanantion as to what is going on in this method and why we are using STATE property and setting DESIRED_STATE only if its not null? ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java <https://reviews.apache.org/r/32540/#comment128052> I assume you also have manually tested the combinations of querying based on "state" and updating based on "state" - Sumit Mohanty On April 6, 2015, 4:57 p.m., Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32540/ > ----------------------------------------------------------- > > (Updated April 6, 2015, 4:57 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, John Speidel, and Sumit > Mohanty. > > > Bugs: AMBARI-4782 > https://issues.apache.org/jira/browse/AMBARI-4782 > > > Repository: ambari > > > Description > ------- > > . > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > f323920 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java > 6536bd5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java > 639e170 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java > f7144b8 > > Diff: https://reviews.apache.org/r/32540/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
