> On Квітень 6, 2015, 5:37 після полудня, Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java, > > line 603 > > <https://reviews.apache.org/r/32540/diff/4/?file=916511#file916511line603> > > > > Is anyone using getRequest(Map<String, Object>) call?
Yes, it will be called during GET host components request. > On Квітень 6, 2015, 5:37 після полудня, Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java, > > line 636 > > <https://reviews.apache.org/r/32540/diff/4/?file=916511#file916511line636> > > > > Can you add some explanantion as to what is going on in this method and > > why we are using STATE property and setting DESIRED_STATE only if its not > > null? This type of request i'm using for DELETE,UPDATE,CREATE host component methods. Before, for all of them it was used getRequest. After getRequest was fixed, all other PUT,POST,DELETE requests start work in new way too...but we don't want this. We want changes only for GET request. For all of these requests, user will set desired_state using API, that's why i'm seting state and desired state -> desired_state(as it was described in your comment in jira). Check for null, maybe is not really needed, but i've added it automatically. > On Квітень 6, 2015, 5:37 після полудня, Sumit Mohanty wrote: > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java, > > line 928 > > <https://reviews.apache.org/r/32540/diff/4/?file=916512#file916512line928> > > > > I assume you also have manually tested the combinations of querying > > based on "state" and updating based on "state" yes, testing it now...all requests and blueprints. - Vitalyi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32540/#review78939 ----------------------------------------------------------- On Квітень 6, 2015, 4:57 після полудня, Vitalyi Brodetskyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32540/ > ----------------------------------------------------------- > > (Updated Квітень 6, 2015, 4:57 після полудня) > > > Review request for Ambari, Dmitro Lisnichenko, John Speidel, and Sumit > Mohanty. > > > Bugs: AMBARI-4782 > https://issues.apache.org/jira/browse/AMBARI-4782 > > > Repository: ambari > > > Description > ------- > > . > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > f323920 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java > 6536bd5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java > 639e170 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java > f7144b8 > > Diff: https://reviews.apache.org/r/32540/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Vitalyi Brodetskyi > >
