----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33462/#review81274 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py <https://reviews.apache.org/r/33462/#comment131565> This function is not being invoked anywhere. Also can you rename test_db_connection_ambaricmd() function name to something like validate_db_connection(). - Jayush Luniya On April 23, 2015, 1:30 a.m., Velmurugan Periasamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33462/ > ----------------------------------------------------------- > > (Updated April 23, 2015, 1:30 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin > Jetly, Jayush Luniya, Mahadev Konar, Sumit Mohanty, and Yusaku Sako. > > > Bugs: AMBARI-10676 > https://issues.apache.org/jira/browse/AMBARI-10676 > > > Repository: ambari > > > Description > ------- > > Logic for DB connection test > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml > aefb200 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > e2b8ba8 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py > 391df2a > > Diff: https://reviews.apache.org/r/33462/diff/ > > > Testing > ------- > > -- tested functionality locally > -- verified python unit tests > > ----------------------------------------------------------------------- > Ran 232 tests in 6.758s > > OK > ---------------------------------------------------------------------- > Total run:675 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Velmurugan Periasamy > >
