> On April 23, 2015, 7:57 a.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml, > > line 36 > > <https://reviews.apache.org/r/33462/diff/1/?file=940137#file940137line36> > > > > Based on your comment "for DB Test connection command", looks like > > these 2 properties are not really used by RANGER service in HDP2.3 stack. > > If that is the case then, I think we can add these 2 properties to > > ranger-env config and then we dont need to add HDP2.3 stack version check. > > > > As an example you can see that ranger-env/ranger_user properties is not > > really written as a property into any of the RANGER config files (i.e. > > /etc/ranger/conf). However the ranger_user property is used by the scripts > > to execute command under. > > > > Of course we might have to validate this for Ambari Upgrade scenario.
looks reasonable to me as well +1 - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33462/#review81284 ----------------------------------------------------------- On April 23, 2015, 7:39 a.m., Velmurugan Periasamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33462/ > ----------------------------------------------------------- > > (Updated April 23, 2015, 7:39 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Aleksandr Kovalenko, Andrew > Onischuk, Jaimin Jetly, Jayush Luniya, Mahadev Konar, Sumit Mohanty, Vitalyi > Brodetskyi, and Yusaku Sako. > > > Bugs: AMBARI-10676 > https://issues.apache.org/jira/browse/AMBARI-10676 > > > Repository: ambari > > > Description > ------- > > Logic for DB connection test > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml > aefb200 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > e2b8ba8 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py > 391df2a > > Diff: https://reviews.apache.org/r/33462/diff/ > > > Testing > ------- > > -- tested functionality locally > -- verified python unit tests > > ----------------------------------------------------------------------- > Ran 232 tests in 6.758s > > OK > ---------------------------------------------------------------------- > Total run:675 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Velmurugan Periasamy > >
