----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33462/#review81289 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py <https://reviews.apache.org/r/33462/#comment131601> Please remove this check it check from Params.py and move it to where the function is actually called. ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py <https://reviews.apache.org/r/33462/#comment131602> Also please remove default(..) this is bad practice. In 2.2 where there is no such a config in will still work. Until the first reference (I guess these variables won't be referenced in 2.2). Meaning we have lazy failing for cases like this. ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py <https://reviews.apache.org/r/33462/#comment131603> I guess here it was intended to check what function to call depending on HDP stack version? - Andrew Onischuk On April 23, 2015, 7:39 a.m., Velmurugan Periasamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33462/ > ----------------------------------------------------------- > > (Updated April 23, 2015, 7:39 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Aleksandr Kovalenko, Andrew > Onischuk, Jaimin Jetly, Jayush Luniya, Mahadev Konar, Sumit Mohanty, Vitalyi > Brodetskyi, and Yusaku Sako. > > > Bugs: AMBARI-10676 > https://issues.apache.org/jira/browse/AMBARI-10676 > > > Repository: ambari > > > Description > ------- > > Logic for DB connection test > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml > aefb200 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > e2b8ba8 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py > 391df2a > > Diff: https://reviews.apache.org/r/33462/diff/ > > > Testing > ------- > > -- tested functionality locally > -- verified python unit tests > > ----------------------------------------------------------------------- > Ran 232 tests in 6.758s > > OK > ---------------------------------------------------------------------- > Total run:675 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Velmurugan Periasamy > >
