----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43125/#review117762 -----------------------------------------------------------
ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana (line 1) <https://reviews.apache.org/r/43125/#comment179038> Why is this file needed? ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml (line 69) <https://reviews.apache.org/r/43125/#comment179037> Is grafana expected to be optional? Can Master be unselected when deploying using UI? ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py (line 32) <https://reviews.apache.org/r/43125/#comment179039> Any plan to package it with AMS/Ambari itself? ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py (line 33) <https://reviews.apache.org/r/43125/#comment179040> This path may need to be explicitly created first. How about non-root ambari server? ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py (line 45) <https://reviews.apache.org/r/43125/#comment179041> why don't we call stop() instead of duplicating stop logic? - Sumit Mohanty On Feb. 3, 2016, 11:05 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43125/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2016, 11:05 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku > Sako. > > > Bugs: AMBARI-14892 > https://issues.apache.org/jira/browse/AMBARI-14892 > > > Repository: ambari > > > Description > ------- > > Add a MASTER component called Grafana to AMS service. > > Include install and start/stop/status scripts for the grafana server. > > Config Management for Ambari Metrics - Grafana also part of this patch. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-timelineservice/conf/unix/ambari-metrics-grafana > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml > 48469df > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py > 8fdf4ba > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py > a1de919 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py > 59466ad > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py > d446baa > > Diff: https://reviews.apache.org/r/43125/diff/ > > > Testing > ------- > > Manual testing done. > > > Thanks, > > Aravindan Vijayan > >
