----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43125/#review117892 -----------------------------------------------------------
Can you please add some unit tests. Changes look good. ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana (line 21) <https://reviews.apache.org/r/43125/#comment179144> .pid ? ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana.ini (line 151) <https://reviews.apache.org/r/43125/#comment179145> Ambari sounds better. ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py (line 66) <https://reviews.apache.org/r/43125/#comment179148> Is this required? This component does not support kerberization. - Sid Wagle On Feb. 4, 2016, 9:35 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43125/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2016, 9:35 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku > Sako. > > > Bugs: AMBARI-14892 > https://issues.apache.org/jira/browse/AMBARI-14892 > > > Repository: ambari > > > Description > ------- > > Add a MASTER component called Grafana to AMS service. > > Include install and start/stop/status scripts for the grafana server. > > Config Management for Ambari Metrics - Grafana also part of this patch. > > > Diffs > ----- > > ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana > 1de5401 > ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana-env.sh 20986cb > ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana.ini e42a92f > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml > 48469df > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py > 8fdf4ba > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py > cf498ec > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py > a1d6a1d > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py > a1de919 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py > 59466ad > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py > d446baa > ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json > a480e2a > > Diff: https://reviews.apache.org/r/43125/diff/ > > > Testing > ------- > > Manual testing done by installing ambari-metrics-grafana rpm on a host and > testing the patch. > > > Thanks, > > Aravindan Vijayan > >
