-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43125/
-----------------------------------------------------------

(Updated Feb. 4, 2016, 11:54 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, Sid Wagle, and Yusaku 
Sako.


Changes
-------

Addressed review comments. 

Added python unit tests for Grafana.

Fixed an issue in Collector while requested for precision data.


Bugs: AMBARI-14892
    https://issues.apache.org/jira/browse/AMBARI-14892


Repository: ambari


Description
-------

Add a MASTER component called Grafana to AMS service.

Include install and start/stop/status scripts for the grafana server.

Config Management for Ambari Metrics - Grafana also part of this patch.


Diffs (updated)
-----

  ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana 
1de5401 
  ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana-env.sh 20986cb 
  ambari-metrics/ambari-metrics-grafana/conf/unix/ams-grafana.ini e42a92f 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 5067454 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractMiniHBaseClusterTest.java
 8cbc56b 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-grafana-ini.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
 48469df 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
 8fdf4ba 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
 cf498ec 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_monitor.py
 a1d6a1d 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 a1de919 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py
 59466ad 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py
 d446baa 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/role_command_order.json 
a480e2a 
  
ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_grafana.py
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json f421aec 

Diff: https://reviews.apache.org/r/43125/diff/


Testing
-------

Manual testing done by installing ambari-metrics-grafana rpm on a host and 
testing the patch.


Thanks,

Aravindan Vijayan

Reply via email to