bodewig commented on PR #116: URL: https://github.com/apache/ant-ivy/pull/116#issuecomment-3902384358
a few comments from the outside: Personally I'm very hesitant when it comes to "reformat" PRs as often they contain more than that. In part they may just reflect differences in matters of taste and you tend to get hung up on discussions about naming (like when you rename `expectedLine` to `expectLine` in https://github.com/apache/ant-ivy/pull/116/changes?w=1#diff-00b84fcbee9a62d669a81fa0ec8262b6e8d8a3a50ec5f2b96166f74dd9f586b3R143 which I'd disagree with - directly after renaming `mergeLine` to `mergedLine` that I'd agree with :-) . Or they introduce changes beyond that, like this PR seems to be adding tests in https://github.com/apache/ant-ivy/pull/116/changes?w=1#diff-00b84fcbee9a62d669a81fa0ec8262b6e8d8a3a50ec5f2b96166f74dd9f586b3R492 - not that I'd opposed to more tests. I wonder whether there is a way to solve the formatting issues separately like agreeing on an [.editorconfig](https://editorconfig.org/) or something similar. WRT the changes to the OSGi versions in MANIFEST.MF. Maybe the file should be generated during the build process rather than having to remember to update it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
