eric-milles commented on PR #116:
URL: https://github.com/apache/ant-ivy/pull/116#issuecomment-3904737408

   The general idea here is that the project had some auto-format applied some 
time ago that makes it difficult for the human reader.  There are some small 
structural changes in `IvyDeliver` and `IvySettings` that provide a nice entry 
point for a planned change.
   
   Changes to tests shouldn't really require such scrutiny IMO since they are 
self-testing.  `expectLine` and `mergedLine` are as such so the names are the 
same length.  I tried to ensure that the tests that were there and relevant to 
IVY-1410 and IVY-1656 tested conditions carefully -- that is, there are now 
checks that demonstrate a difference in behavior when I add my fix.
   
   As for the manifest, it should just say 2.6.0 across the board.  But I am 
trying to add changes little-by-little at this point.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to