bodewig commented on PR #116: URL: https://github.com/apache/ant-ivy/pull/116#issuecomment-3904787765
> Changes to tests shouldn't really require such scrutiny IMO Let's say we've had pretty bad experience with big commits that claimed to do thing A and also did B - which caused subtle bugs. I'm not going to do with "not much scrutiny" anymore. Call it a personal weakness :-) > expectLine and mergedLine are as such so the names are the same length. This is not anything I would have ever thought about. And it is an example for "differences in taste". In the end we'll end up arguing about the color of the bike shed longer than about what you really wanted to change. > As for the manifest, it should just say 2.6.0 across the board. Unless the next release is 2.5.4 ... That's why I believe creating it in an automated way based on the version being built would be better - as a completely separate issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
